workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	David Epping <david.epping@missinglinkelectronics.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Harini Katakam <harini.katakam@amd.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <workflows@vger.kernel.org>
Subject: Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write
Date: Tue, 5 Dec 2023 11:58:14 -0800	[thread overview]
Message-ID: <91dcd8c3-ae86-4350-838d-62ddb62fa2bb@quicinc.com> (raw)
In-Reply-To: <ZW9oc9TO93kOq20s@shell.armlinux.org.uk>

On 12/5/2023 10:14 AM, Russell King (Oracle) wrote:
> On Tue, Dec 05, 2023 at 09:44:05AM -0800, Jeff Johnson wrote:
>> So in my experience a function prototype IS the function definition, and
>> the actual function is just the implementation of that definition.
>>
>> But that thinking obviously isn't shared by others.
> 
> Interestingly, the view that a function prototype is a function
> definition does not seem to be shared by w3school, Microsoft, IBM,
> and many more.
> 
> If we look at the C99 standard, then 6.9.1 Function definitions gives
> the syntax as including a compound-statement, which is defined as
> requiring the curley braces and contents. Therefore, a function
> definition as defined by the C standard includes its body.
> 

Note I was speaking in terms of functional languages in general, not C
specifically. Perhaps I should have used the term "specification"
instead of "definition" (which would align with the Ada terminology).

Having worked with closed-source systems, especially VxWorks, for many
years (where the header files contain all the documentation), it just
seems strange to embed the documentation in the .c files.

/jeff



  reply	other threads:[~2023-12-05 19:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20231128133630.7829-1-ansuelsmth@gmail.com>
     [not found] ` <20231128133630.7829-3-ansuelsmth@gmail.com>
     [not found]   ` <20231204181752.2be3fd68@kernel.org>
     [not found]     ` <51aae9d0-5100-41af-ade0-ecebeccbc418@lunn.ch>
     [not found]       ` <656f37a6.5d0a0220.96144.356f@mx.google.com>
     [not found]         ` <adbe5299-de4a-4ac1-90d0-f7ae537287d0@lunn.ch>
     [not found]           ` <ZW89errbJWUt33vz@shell.armlinux.org.uk>
2023-12-05 15:29             ` Jakub Kicinski
2023-12-05 16:11               ` Russell King (Oracle)
2023-12-05 17:44                 ` Jeff Johnson
2023-12-05 18:14                   ` Russell King (Oracle)
2023-12-05 19:58                     ` Jeff Johnson [this message]
2023-12-05 20:11                       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91dcd8c3-ae86-4350-838d-62ddb62fa2bb@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=david.epping@missinglinkelectronics.com \
    --cc=edumazet@google.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=harini.katakam@amd.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox