workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] docs: submitting-patches: document the format for affiliation
Date: Mon, 10 Feb 2025 11:38:46 -0700	[thread overview]
Message-ID: <87cyfpzlu1.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20250203174626.1131225-1-kuba@kernel.org>

Jakub Kicinski <kuba@kernel.org> writes:

> Adding company name in round brackets to From/SoB lines
> is fairly common, but I don't see it documented anywhere.
> Every now and then people try to add the sponsorship lines
> to the commit message, fun example from this merge window:
>
>   Sponsored by:   The FreeBSD Foundation
>
> from commit 2ce67f8bf1ce ("wifi: iwlwifi: mvm: fix iwl_ssid_exist()
> check"). Better format would be:
>
>   Author: Miri Korenblit (FreeBSD Foundation) <...
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: corbet@lwn.net
> CC: workflows@vger.kernel.org
> CC: linux-doc@vger.kernel.org
> ---
>  Documentation/process/submitting-patches.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 8fdc0ef3e604..12ed28b3d113 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -717,6 +717,12 @@ patch in the permanent changelog.  If the ``from`` line is missing,
>  then the ``From:`` line from the email header will be used to determine
>  the patch author in the changelog.
>  
> +The author may indicate their affiliation or the sponsor of the work
> +by adding the name of an organization to the ``from`` and ``SoB`` lines,
> +e.g.:
> +
> +	From: Patch Author (Company) <author@example.com>
> +
>  Explanation Body
>  ^^^^^^^^^^^^^^^^

So, despite all the conversation, I didn't see any real opposition to
adding this change, so I've applied it.

Amusingly, b4 helpfully picked up these tags from the conversation:

 + Signed-off-by: John Doe <jdoe@example.com> (✓DKIM/infradead.org)
 + Signed-off-by: Mr Maintainer <jdoe@example.com> (✓DKIM/kernel.org)
 + Signed-off-by: Jane Maintainer <jdoe@example.com>

Tempting as it was to leave them in, I took them out :)

Thanks,

jon

  parent reply	other threads:[~2025-02-10 18:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-03 17:46 Jakub Kicinski
2025-02-04  7:59 ` Geert Uytterhoeven
2025-02-04 15:18   ` Jakub Kicinski
2025-02-04 15:49     ` Laurent Pinchart
2025-02-04 16:13       ` Jakub Kicinski
2025-02-04 18:05         ` Randy Dunlap
2025-02-04 19:33           ` Jakub Kicinski
2025-02-04 19:43             ` Geert Uytterhoeven
2025-02-04 19:43           ` Konstantin Ryabitsev
2025-02-05  7:37 ` Yanteng Si
2025-02-05 14:23   ` Krzysztof Kozlowski
2025-02-05 14:52     ` Yanteng Si
2025-02-05 14:57       ` Krzysztof Kozlowski
2025-02-06  8:21         ` Yanteng Si
2025-02-10 18:38 ` Jonathan Corbet [this message]
2025-02-10 18:45   ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyfpzlu1.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox