From: Mark Brown <broonie@kernel.org>
To: Barry Song <21cnbao@gmail.com>
Cc: corbet@lwn.net, workflows@vger.kernel.org,
linux-doc@vger.kernel.org, apw@canonical.com, joe@perches.com,
dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
linux-kernel@vger.kernel.org, Barry Song <v-songbaohua@oppo.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Zankel <chris@zankel.net>,
Huacai Chen <chenhuacai@loongson.cn>,
Herbert Xu <herbert@gondor.apana.org.au>,
Guenter Roeck <linux@roeck-us.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH v3 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters
Date: Fri, 22 Mar 2024 14:33:03 +0000 [thread overview]
Message-ID: <7d965b3a-c857-4498-aea9-5a3ad8ad5b76@sirena.org.uk> (raw)
In-Reply-To: <20240322084937.66018-2-21cnbao@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Fri, Mar 22, 2024 at 09:49:36PM +1300, Barry Song wrote:
> The driver code, for itself, seems be quite innocent and placing
> maybe_unused seems pointless,
>
> struct page *dst_page = sg_page(req->dst);
>
> for (i = 0; i < nr_pages; i++)
> flush_dcache_page(dst_page + i);
>
> And it should be independent of architectural implementation
> differences.
>
> Let's provide guidance on coding style for requesting parameter
> evaluation or proposing the migration to a static inline
> function.
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-22 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 8:49 [PATCH v3 0/2] codingstyle: avoid unused parameters for a function-like macro Barry Song
2024-03-22 8:49 ` [PATCH v3 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters Barry Song
2024-03-22 14:33 ` Mark Brown [this message]
2024-03-22 8:49 ` [PATCH v3 2/2] scripts: checkpatch: Check unused parameters for function-like macro Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d965b3a-c857-4498-aea9-5a3ad8ad5b76@sirena.org.uk \
--to=broonie@kernel.org \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=chenhuacai@loongson.cn \
--cc=chris@zankel.net \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jcmvbkbc@gmail.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukas.bulwahn@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=v-songbaohua@oppo.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox