From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7917034B40E for ; Mon, 6 Apr 2026 21:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775510060; cv=none; b=aGGsOv1KiLTzdxQADKd8YGMtFy7TBjP97313nHQFrXaqU2THgQ3v/W6ML82S0a8qpScpJuEi7+dhFNTQyhSqxdo9o6mK34LdlPTtUKMU6Wf6VjECREC/MWwL5m2mCt0Ij374YkvkU2jtbrPaDmmvG/VB3ODPHc4mjTYHX9cqb1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775510060; c=relaxed/simple; bh=yQI2hucAupVyRTWavsrdMoHVdq2ezUeT7+RpkygVu2M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c6lbUoaH1Q90UrG8ZJTtUbBGtVPPcCmLdfn38npvSMRA/lIGPBxleNEF0//k9h/j/HCCh0i1Qk5UyJ9pa1Sb4farTvp4IpWQsUkEeLZ7FbpVjZo6twt4SAfVOl0EaBjp63BFiUpGhV3jdhdlGD4/mIAfyfV6HNJ1hcr7G5baOVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=EAm+McgM; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=HYuA/k3/; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=EAm+McgM; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=HYuA/k3/; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="EAm+McgM"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="HYuA/k3/"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="EAm+McgM"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="HYuA/k3/" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 67A4E5BD48; Mon, 6 Apr 2026 21:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775510056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1AWo8CavFFDUlQFTl1sblytoQrwi8RwdUfstHMGxg+Y=; b=EAm+McgMWvEAMWzObHTx5Axb3fmCwBU0rGxqEVoiZoOOvxyqcPUI8Nlrf50XsECTNtS5Zu sKWHMdRNG30Wg0rYlRUpr4pPQU2rTdSJcp5kn6xf5lJ+jDpQakCwBaQ68R0lkaKp1h5y0H 4xQflKCvnaXGPdRDkI1Kt4WLkPwsU8g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775510056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1AWo8CavFFDUlQFTl1sblytoQrwi8RwdUfstHMGxg+Y=; b=HYuA/k3/GZPXBvbMfFl+BEq/hGp+lC9TNAEl3vG4WHvxayJBKVY2kV+4G6cmjj+CZisXcL xblREPEQazCPAdCQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EAm+McgM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="HYuA/k3/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775510056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1AWo8CavFFDUlQFTl1sblytoQrwi8RwdUfstHMGxg+Y=; b=EAm+McgMWvEAMWzObHTx5Axb3fmCwBU0rGxqEVoiZoOOvxyqcPUI8Nlrf50XsECTNtS5Zu sKWHMdRNG30Wg0rYlRUpr4pPQU2rTdSJcp5kn6xf5lJ+jDpQakCwBaQ68R0lkaKp1h5y0H 4xQflKCvnaXGPdRDkI1Kt4WLkPwsU8g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775510056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1AWo8CavFFDUlQFTl1sblytoQrwi8RwdUfstHMGxg+Y=; b=HYuA/k3/GZPXBvbMfFl+BEq/hGp+lC9TNAEl3vG4WHvxayJBKVY2kV+4G6cmjj+CZisXcL xblREPEQazCPAdCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9F3BB4A0B0; Mon, 6 Apr 2026 21:14:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bNdzIyci1GnQewAAD6G6ig (envelope-from ); Mon, 06 Apr 2026 21:14:15 +0000 Message-ID: <7b3c4791-674a-4420-879a-98b243827b63@suse.de> Date: Mon, 6 Apr 2026 23:14:15 +0200 Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] docs: netdev: document AI-assisted review tooling To: Nicolai Buchwitz Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , netdev@vger.kernel.org, workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mbloch@nvidia.com References: <20260406-nb-docs-ai-review-v1-1-b58943762ca9@tipi-net.de> <345722f0-21b1-4970-8c45-ef85edf9d45b@suse.de> <56c5bdfe2e37738e47b3b4d22e21697c@tipi-net.de> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: <56c5bdfe2e37738e47b3b4d22e21697c@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[13]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[linux.dev:url,suse.de:dkim,suse.de:mid,sashiko.dev:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,lwn.net:url]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 67A4E5BD48 X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: On 4/6/26 10:24 PM, Nicolai Buchwitz wrote: > On 6.4.2026 21:58, Fernando Fernandez Mancera wrote: >> [...] > >> >> Hi Nicolai, >> maybe I am missing something but [2] isn't from sashiko.dev but from >> netdev AI CI instead. See: https://netdev-ai.bots.linux.dev/ai- >> review.html?id=0b114a22-9aab-4265-8bfc-ea1b5bca5514 > > You're right, I mixed up the two systems - the example I linked was > from the netdev AI bot, not Sashiko. My mistake on the link. > > I stumbled over Sashiko when I noticed the name appearing more often > in other reviews and then found Jonathan's LWN article about it [1]. > > Both tools are actively reviewing patches on the list today. I think > it makes sense to document both rather than just one: > > The netdev AI bot at netdev-ai.bots.linux.dev > Sashiko at sashiko.dev, which posts reviews publicly on its website > Both use the same review prompts by Chris Mason [2], so there is > common ground - though results will vary between them due to the > different AI models (Claude Opus for netdev-ai, Gemini for Sashiko) > on top of the usual AI uncertainty. > > I think it would be useful to document that AI reviews are happening > but mixing AI bots might confuse people. > > Agreed, I'll rework the patch to distinguish the two systems once > the discussion has been settled. > >> >> The documentation mentioned for running the AI locally is correctly >> related to netdev AI bot. >> >> I think it would be useful to document that AI reviews are happening >> but mixing AI bots might confuse people. >> >>> Check for findings on your submissions and address >>> +valid ones before a maintainer has to relay the same questions. >>> + >> >> I wonder what would be the consequences for this. If less experienced >> submitters are expected to address issues pointed out by AI bots they >> might work on something that isn't valid. AFAIU, the AI output is only >> forwarded to the submitter after a maintainer reviewed it and believes >> it makes sense. > > Fair point. The wording should make clear that the local tooling is > an optional aid, not an obligation. I'll soften the language around > addressing findings. > Thank you! Regarding this topic it seems people have been already discussing this around other subsystems [1]. It might be useful to check out similar discussions and outcomes. [1] https://lwn.net/Articles/1064830/ > Would appreciate input on how much detail is appropriate here - > should the doc just acknowledge that AI review exists and point to > the tooling, or go into more detail about the workflow? > To be honest that is hard for me to tell, I am not a maintainer and not the one doing the forwarding currently. I think there isn't an official workflow regarding this. Maybe a good starter would be to just mention that they exist. Or maybe this is a good opportunity to define an official workflow! Thanks, Fernando.