From: Joe Perches <joe@perches.com>
To: Barry Song <21cnbao@gmail.com>, Jonathan Corbet <corbet@lwn.net>
Cc: akpm@linux-foundation.org, linux-doc@vger.kernel.org,
workflows@vger.kernel.org, apw@canonical.com,
broonie@kernel.org, chenhuacai@loongson.cn, chris@zankel.net,
dwaipayanray1@gmail.com, herbert@gondor.apana.org.au,
linux-kernel@vger.kernel.org, linux@roeck-us.net,
lukas.bulwahn@gmail.com, mac.xxn@outlook.com,
sfr@canb.auug.org.au, v-songbaohua@oppo.com,
Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH v5 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters
Date: Tue, 02 Apr 2024 14:54:34 -0700 [thread overview]
Message-ID: <69ee112aadc8ef8ed7d819308f02dc58e56bb0a6.camel@perches.com> (raw)
In-Reply-To: <CAGsJ_4x=YaGotZwRxjaRhELi=ExVcQ+euEkSiZ2GkAoLFwhMVw@mail.gmail.com>
On Wed, 2024-04-03 at 10:21 +1300, Barry Song wrote:
> On Wed, Apr 3, 2024 at 5:13 AM Jonathan Corbet <corbet@lwn.net> wrote:
> >
> > So I'm not sure what your desired path for getting this upstream is. I
> > can take it, but I'm generally quite leery of taking coding-style
> > changes without some serious acks on them - nobody elected me as the
> > arbiter of proper coding style.
I believe it is generally appropriate for macros that take
arguments to use static inlines where feasible, so:
Acked-by: Joe Perches <joe@perches.com>
And yes, mm is the usual path for upstreaming at least this
sort of checkpatch change.
next prev parent reply other threads:[~2024-04-02 21:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 1:21 [PATCH v5 0/2] codingstyle: avoid unused parameters for a function-like macro Barry Song
2024-04-01 1:21 ` [PATCH v5 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters Barry Song
2024-04-02 16:13 ` Jonathan Corbet
2024-04-02 21:21 ` Barry Song
2024-04-02 21:54 ` Joe Perches [this message]
2024-04-01 1:21 ` [PATCH v5 2/2] scripts: checkpatch: check unused parameters for function-like macro Barry Song
2024-04-01 2:37 ` Joe Perches
2024-04-02 0:16 ` Mac Xu
2024-04-02 1:39 ` Joe Perches
2024-04-02 15:05 ` Mac Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69ee112aadc8ef8ed7d819308f02dc58e56bb0a6.camel@perches.com \
--to=joe@perches.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=broonie@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=chris@zankel.net \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jcmvbkbc@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukas.bulwahn@gmail.com \
--cc=mac.xxn@outlook.com \
--cc=sfr@canb.auug.org.au \
--cc=v-songbaohua@oppo.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox