workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Joe Perches" <joe@perches.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	workflows@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	"Thorsten Leemhuis" <linux@leemhuis.info>,
	"Kees Cook" <kees@kernel.org>,
	linux-kernel@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status
Date: Tue, 11 Feb 2025 16:30:48 +0100	[thread overview]
Message-ID: <68bb307a-26ad-46ac-a9de-bec9b808506a@suse.cz> (raw)
In-Reply-To: <CAMuHMdXNaNPiVXMrqf4YqM-PRC6ZrTgmHtOP1S9PPCP2HqvGWA@mail.gmail.com>

On 2/11/25 16:19, Geert Uytterhoeven wrote:
> Hi Vlastimil,
> 
> On Tue, 11 Feb 2025 at 15:58, Vlastimil Babka <vbabka@suse.cz> wrote:
>> On 2/11/25 11:48, Geert Uytterhoeven wrote:
>> I've tried to do that in v1 in the form of reporting e.g. as
>> John Doe <jd@example.com> (maintainer:SUBSYSTEM [supported])
>>
>> But it seemed noisy to repeat that on every line involving the subsystem.
> 
> Yeah, it could be considered noisy... (more below)
> 
>> When you say comment, what kind of separation for the comment would work
>> regardless of what's used for postprocessing?
> 
> I don't mind much. Perhaps just a comma?

Hm comma where exactly? Sorry I might not get it, could you provide a full
example? Thanks.

>> > Now, as both Uwe and I edit our generated scripts before running them,
>> > we can delete the unwanted lines, but it's more work...
>> > Thanks!
>>
>> I guess technically your scripts could detect first if --no-substatus is
>> supported by grepping --help or testing if passing the option results in an
>> error? But yeah it's not ideal, looks like I've hit the limits of automagic
>> heuristics here.
>> Or we make it fully opt-in but then most non-scripting users will not learn
>> the status at all because it won't occur to them to enable it...
> 
> I still seem to miss the real story behind this patch (so perhaps
> that's why I would consider all of it noisy ;-). When I create a patch,

The cover letter tells the story. It comes back to the way the script
reports maintainers as "supporter"s (or other roles according to the status,
however some status means there is most likely no maintainer). Joe objected
to that status reporting would be simply removed in [1]. I also think it's
useful information for the submitters, so I try to provide it differently.

> what am I gonna do with this extra information?
> E.g. decide not to send the patch, because the driver is orphaned?

Well for example you can know that you might not get a timely reply, or
might need to step up as a maintainer. Or you're trying to add a feature and
the driver is "odd fixes". I think we do document the status in MAINTAINERS
for a reason, and one could expect the tool to provide it and not require
you to go look into MAINTAINERS yourself.

[1]
https://lore.kernel.org/all/30776fe75061951777da8fa6618ae89bea7a8ce4.camel@perches.com/

> Thanks!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 


  reply	other threads:[~2025-02-11 16:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-03 11:13 [PATCH v2 0/2] get_maintainer: report subsystem status separately from maintainer role Vlastimil Babka
2025-02-03 11:13 ` [PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status Vlastimil Babka
2025-02-04 10:19   ` Lorenzo Stoakes
2025-02-11 10:32   ` Uwe Kleine-König
2025-02-11 10:48     ` Geert Uytterhoeven
2025-02-11 10:59       ` Vlastimil Babka
2025-02-11 11:05         ` Vlastimil Babka
2025-02-11 15:19         ` Geert Uytterhoeven
2025-02-11 15:30           ` Vlastimil Babka [this message]
2025-02-11 16:28             ` Geert Uytterhoeven
2025-02-11 18:39               ` Vlastimil Babka
2025-02-11 15:09       ` Uwe Kleine-König
2025-02-11 15:22         ` Geert Uytterhoeven
2025-02-11 15:20   ` Vlastimil Babka
2025-02-12 12:42     ` Geert Uytterhoeven
2025-02-12 14:53       ` Uwe Kleine-König
2025-02-03 11:13 ` [PATCH v2 2/2] get_maintainer: stop reporting subsystem status as maintainer role Vlastimil Babka
2025-02-04 10:18   ` Lorenzo Stoakes
2025-02-04 10:12 ` [PATCH v2 0/2] get_maintainer: report subsystem status separately from " Lorenzo Stoakes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68bb307a-26ad-46ac-a9de-bec9b808506a@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=geert@linux-m68k.org \
    --cc=joe@perches.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=tytso@mit.edu \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox