From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Jakub Kicinski <kuba@kernel.org>
Cc: Joe Perches <joe@perches.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
geert@linux-m68k.org, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, workflows@vger.kernel.org
Subject: Re: [PATCH v2] scripts: get_maintainer: steer people away from using file paths
Date: Wed, 26 Jul 2023 13:45:38 -0500 [thread overview]
Message-ID: <63361a8f-ffa5-50e7-97d6-297d8e8b059f@amd.com> (raw)
In-Reply-To: <CAHk-=wi9MyyWmP_HAddLrmGfdANkut6_2f9hzv9HcyTBvg3+kA@mail.gmail.com>
On 7/26/2023 1:29 PM, Linus Torvalds wrote:
> On Wed, 26 Jul 2023 at 11:20, Jakub Kicinski <kuba@kernel.org> wrote:
>>
>> You are special,
>
> So my mother tells me.
>
>> you presumably use it to find who to report
>> regressions to, and who to pull into conversations.
>
> Yes. So what happens is that I get cc'd on bug reports for various
> issues, and particularly for oops reports I basically have a function
> name to grep for (maybe a pathname if it went through the full
> decoding).
>
> I'm NOT interested in having to either remember all people off-hand,
> or going through the MAINTAINERS file by hand.
>
>> This tool is primarily used by _developers_ to find _maintainers_.
>
> Well, maybe.
>
> But even if that is true, I don't see why you hate the pathname thing
> even for that case. I bet developers use it for that exact same
> reason, ie they are modifying a file, and they go "I want to know who
> the maintainer for this file is".
>
> I do not understand why you think a patch is somehow magically more
> important or relevant than a filename.
>
> Linus
If the goal is to get people who are involved with a file, how about
some variation of:
git log --pretty=format:%ae $PATH | sort | uniq
Granted this is going to be overkill, for example I can see on
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c that it would email 198 people.
next prev parent reply other threads:[~2023-07-26 18:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 15:15 Jakub Kicinski
2023-07-26 15:20 ` Mario Limonciello
2023-07-26 15:43 ` Joe Perches
2023-07-26 16:23 ` Jakub Kicinski
2023-07-26 16:45 ` Linus Torvalds
2023-07-26 16:51 ` Joe Perches
2023-07-26 18:20 ` Jakub Kicinski
2023-07-26 18:29 ` Linus Torvalds
2023-07-26 18:45 ` Limonciello, Mario [this message]
2023-07-26 18:48 ` Linus Torvalds
2023-07-26 18:48 ` Jakub Kicinski
2023-07-26 18:59 ` Linus Torvalds
2023-07-26 19:05 ` Linus Torvalds
2023-07-26 19:37 ` Linus Torvalds
2023-07-26 20:03 ` Jakub Kicinski
2023-07-26 20:13 ` Linus Torvalds
2023-07-26 20:36 ` Jakub Kicinski
2023-07-26 21:07 ` Linus Torvalds
2023-07-26 21:57 ` Jakub Kicinski
2023-07-26 22:02 ` Linus Torvalds
2023-07-26 22:15 ` Linus Torvalds
2023-07-26 23:47 ` Konstantin Ryabitsev
2023-07-27 0:11 ` Jakub Kicinski
2023-07-27 0:24 ` Konstantin Ryabitsev
2023-07-27 0:27 ` Jakub Kicinski
2023-07-27 0:33 ` Konstantin Ryabitsev
2023-07-27 1:07 ` Joe Perches
2023-07-27 11:00 ` Andrew Lunn
2023-07-28 20:29 ` Konstantin Ryabitsev
2023-07-28 20:38 ` Jakub Kicinski
2023-07-28 20:50 ` Konstantin Ryabitsev
2023-07-29 0:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63361a8f-ffa5-50e7-97d6-297d8e8b059f@amd.com \
--to=mario.limonciello@amd.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox