From: Joe Perches <joe@perches.com>
To: Barry Song <21cnbao@gmail.com>,
akpm@linux-foundation.org, linux-doc@vger.kernel.org
Cc: apw@canonical.com, broonie@kernel.org, chenhuacai@loongson.cn,
chris@zankel.net, corbet@lwn.net, dwaipayanray1@gmail.com,
herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
linux@roeck-us.net, lukas.bulwahn@gmail.com,
mac.xxn@outlook.com, sfr@canb.auug.org.au,
v-songbaohua@oppo.com, workflows@vger.kernel.org,
Max Filippov <jcmvbkbc@gmail.com>,
Jeff Johnson <quic_jjohnson@quicinc.com>,
Charlemagne Lasse <charlemagnelasse@gmail.com>
Subject: Re: [PATCH RESEND v6 2/2] scripts: checkpatch: check unused parameters for function-like macro
Date: Sun, 05 May 2024 22:33:18 -0700 [thread overview]
Message-ID: <5e26f82913801050afa4442dfb9a07249895ab98.camel@perches.com> (raw)
In-Reply-To: <20240506014606.8638-3-21cnbao@gmail.com>
On Mon, 2024-05-06 at 13:46 +1200, Barry Song wrote:
> From: Xining Xu <mac.xxn@outlook.com>
>
> If function-like macros do not utilize a parameter, it might result in a
> build warning. In our coding style guidelines, we advocate for utilizing
> static inline functions to replace such macros. This patch verifies
> compliance with the new rule.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -6040,6 +6040,12 @@ sub process {
> CHK("MACRO_ARG_PRECEDENCE",
> "Macro argument '$arg' may be better as '($arg)' to avoid precedence issues\n" . "$herectx");
> }
> +
> +# check if this is an unused argument
> + if ($define_stmt !~ /\b$arg\b/) {
> + WARN("MACRO_ARG_UNUSED",
> + "Argument '$arg' is not used in function-like macro\n" . "$herectx");
trivia: This should be aligned to the open parenthesis.
Otherwise:
Acked-by: Joe Perches <joe@perches.com>
next prev parent reply other threads:[~2024-05-06 5:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 1:46 [PATCH RESEND v6 0/2] codingstyle: avoid unused parameters for a " Barry Song
2024-05-06 1:46 ` [PATCH RESEND v6 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters Barry Song
2024-05-06 1:46 ` [PATCH RESEND v6 2/2] scripts: checkpatch: check unused parameters for function-like macro Barry Song
2024-05-06 5:33 ` Joe Perches [this message]
2024-05-06 7:16 ` Barry Song
2024-05-06 16:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e26f82913801050afa4442dfb9a07249895ab98.camel@perches.com \
--to=joe@perches.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=broonie@kernel.org \
--cc=charlemagnelasse@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=chris@zankel.net \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jcmvbkbc@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukas.bulwahn@gmail.com \
--cc=mac.xxn@outlook.com \
--cc=quic_jjohnson@quicinc.com \
--cc=sfr@canb.auug.org.au \
--cc=v-songbaohua@oppo.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox