workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thorsten Leemhuis <linux@leemhuis.info>
To: Jonathan Corbet <corbet@lwn.net>,
	workflows@vger.kernel.org, regressions@lists.linux.dev,
	linux-doc@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Greg KH <gregkh@linuxfoundation.org>
Subject: [PATCH v1 4/6] docs: 6.Followthrough.rst: tags to use in regressions fixes
Date: Tue, 10 Dec 2024 11:15:13 +0100	[thread overview]
Message-ID: <5913a87f05a5fe53afb9aae151f60f83bda128e8.1733825632.git.linux@leemhuis.info> (raw)
In-Reply-To: <cover.1733825632.git.linux@leemhuis.info>

Add a few notes on the appropriate tags to be used in changes that fix
regressions.

This removes equivalent paragraphs from a section in
Documentation/process/handling-regressions.rst, which will become mostly
obsolete through this and follow-up changes.

Signed-off-by: Thorsten Leemhuis <linux@leemhuis.info>
---

Note:

* Not sure if the "add a second Fixes: tag for the change that exposed
  an earlier problem" is appropriate, but it results in the most
  reliable solution without much overhead.

* On a brief look it might seem like this changes the "participation in
  stable is optional for mainline developers" approach. But that is not
  the case, as the point is just kindly asking developers to take care
  of stable inclusion.
---
 Documentation/process/6.Followthrough.rst      | 16 ++++++++++++++++
 Documentation/process/handling-regressions.rst |  7 -------
 2 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/Documentation/process/6.Followthrough.rst b/Documentation/process/6.Followthrough.rst
index 763a80d21240f0..2ba16a71aba9b4 100644
--- a/Documentation/process/6.Followthrough.rst
+++ b/Documentation/process/6.Followthrough.rst
@@ -234,6 +234,22 @@ On procedure:
    requests again should ideally come directly from maintainers or happen in
    accordance with them.
 
+On tags in the patch description of regressions fixes:
+
+ - Include the tags Documentation/process/5.Posting.rst mentions for
+   regressions; this usually means a "Reported-by:" tag followed by "Link:" or
+   "Closes:" tag pointing to the report as well as a "Fixes:" tag; if it's a
+   regression a later change exposed, add a "Fixes:" tag for that one, too.
+
+ - Did the culprit make it into a proper mainline release during the past
+   twelve months? Or is it a recent mainline commit backported to stable or
+   longterm releases in the past few weeks? Then you are kindly asked to ensure
+   stable inclusion as described by Documentation/process/stable-kernel-rules.rst.
+   Usually you want to realized thos by adding a "Cc: stable@vger.kernel.org" to
+   the patch description.  Note, a "Fixes:" tag alone does not guarantee a
+   backport, as the stable team does not pick up all such changes and might
+   silently drop them in case trouble arises.
+
 Regarding stable and longterm series:
 
  - You are free to leave handling regressions to the stable team if the problem
diff --git a/Documentation/process/handling-regressions.rst b/Documentation/process/handling-regressions.rst
index cfb44a9928d450..da53e12fc6d96c 100644
--- a/Documentation/process/handling-regressions.rst
+++ b/Documentation/process/handling-regressions.rst
@@ -196,13 +196,6 @@ On procedure:
    regressions to be handled like those from the current cycle, unless fixing
    bears unusual risks.
 
-Regarding stable and longterm kernels:
-
- * If a regression made it into a proper mainline release during the past
-   twelve months, ensure to tag the fix with "Cc: stable@vger.kernel.org", as a
-   "Fixes:" tag alone does not guarantee a backport. Please add the same tag,
-   in case you know the culprit was backported to stable or longterm kernels.
-
 On patch flow:
 
  * Developers, when trying to reach the time periods mentioned above, remember
-- 
2.45.0


  parent reply	other threads:[~2024-12-10 10:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10 10:15 [PATCH v1 0/6] docs: add instruction about handling regressions to our core texts for contributors Thorsten Leemhuis
2024-12-10 10:15 ` [PATCH v1 1/6] docs: more detailed instructions on handling regressions Thorsten Leemhuis
2024-12-13 16:14   ` Jonathan Corbet
2024-12-20 12:17     ` Thorsten Leemhuis
2024-12-10 10:15 ` [PATCH v1 2/6] docs: 6.Followthrough.rst: when to involved Linus in regressions Thorsten Leemhuis
2024-12-13 16:17   ` Jonathan Corbet
2024-12-20 12:41     ` Thorsten Leemhuis
2024-12-10 10:15 ` [PATCH v1 3/6] docs: 6.Followthrough.rst: interaction with stable wrt to regressions Thorsten Leemhuis
2024-12-13 16:20   ` Jonathan Corbet
2024-12-20 13:13     ` Thorsten Leemhuis
2024-12-10 10:15 ` Thorsten Leemhuis [this message]
2024-12-13 16:24   ` [PATCH v1 4/6] docs: 6.Followthrough.rst: tags to use in regressions fixes Jonathan Corbet
2024-12-20 13:18     ` Thorsten Leemhuis
2024-12-10 10:15 ` [PATCH v1 5/6] docs: 6.Followthrough.rst: more specific advice on fixing regressions Thorsten Leemhuis
2024-12-13 16:28   ` Jonathan Corbet
2024-12-20 14:21     ` Thorsten Leemhuis
2024-12-10 10:15 ` [PATCH v1 6/6] docs: 6.Followthrough.rst: advice on handling regressions fixes Thorsten Leemhuis
2024-12-13 16:30   ` Jonathan Corbet
2024-12-20 14:24     ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5913a87f05a5fe53afb9aae151f60f83bda128e8.1733825632.git.linux@leemhuis.info \
    --to=linux@leemhuis.info \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=torvalds@linux-foundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox