workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thorsten Leemhuis <linux@leemhuis.info>
To: Bagas Sanjaya <bagasdotme@gmail.com>, Jonathan Corbet <corbet@lwn.net>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Simona Vetter <simona.vetter@ffwll.ch>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v4] docs: clarify rules wrt tagging other people
Date: Fri, 7 Feb 2025 09:24:56 +0100	[thread overview]
Message-ID: <559e84cc-4da3-45a5-9ff0-2283d2c53d0a@leemhuis.info> (raw)
In-Reply-To: <Z6Vk-7OgDB3DM7Yb@archie.me>

On 07.02.25 02:42, Bagas Sanjaya wrote:
> On Thu, Feb 06, 2025 at 03:30:10PM +0100, Thorsten Leemhuis wrote:
>> diff --git a/Documentation/process/5.Posting.rst b/Documentation/process/5.Posting.rst
>> index dbb763a8de901d..22fa925353cf54 100644
>> --- a/Documentation/process/5.Posting.rst
>> +++ b/Documentation/process/5.Posting.rst
>> @@ -268,10 +268,15 @@ The tags in common use are:
>>   - Cc: the named person received a copy of the patch and had the
>>     opportunity to comment on it.
>>  
>> -Be careful in the addition of tags to your patches, as only Cc: is appropriate
>> -for addition without the explicit permission of the person named; using
>> -Reported-by: is fine most of the time as well, but ask for permission if
>> -the bug was reported in private.
>> +Be careful in the addition of the aforementioned tags to your patches, as all
>> +except for Cc:, Reported-by:, and Suggested-by: need explicit permission of the
>> +person named. For those three implicit permission is sufficient if the person
>> +contributed to the Linux kernel using that name and email address according
>> +to the lore archives or the commit history -- and in case of Reported-by:
>> +and Suggested-by: did the reporting or suggestion in public. Note,
>> +bugzilla.kernel.org is a public place in this sense, but email addresses
>> +used there are private; so do not expose them in tags, unless the person
>> +used them in earlier contributions.
> 
> So for example I can only include Tested-by: when a contributor who tested
> my patch explicitly offer the tag by replying to it i.e. with the tag, right?

At some point a text must leave the interpretation up to the reader. I
would say a "yes, that's okay" to the question "is it okay to add a
'tested-by' tag in the patch description; note, your name and email
address will then end up in the commit history and can not be removed
there" is sufficient "permission" as well.

> The wording looks OK.
> 
> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

Thx!

Ciao, Thorsten



  reply	other threads:[~2025-02-07  8:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06 14:30 Thorsten Leemhuis
2025-02-07  1:42 ` Bagas Sanjaya
2025-02-07  8:24   ` Thorsten Leemhuis [this message]
2025-02-10 16:16     ` Mauro Carvalho Chehab
2025-02-11  8:45       ` Thorsten Leemhuis
2025-02-07  9:05 ` Laurent Pinchart
2025-02-08 15:36   ` Thorsten Leemhuis
2025-02-10 11:15     ` Laurent Pinchart
2025-02-11  8:43       ` Thorsten Leemhuis
2025-02-10 18:12 ` Jonathan Corbet
2025-02-11  8:48   ` Thorsten Leemhuis
2025-02-18 20:42     ` Jonathan Corbet
2025-03-06 13:31       ` Thorsten Leemhuis
2025-03-12 22:39         ` Jonathan Corbet
2025-03-17 22:49           ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559e84cc-4da3-45a5-9ff0-2283d2c53d0a@leemhuis.info \
    --to=linux@leemhuis.info \
    --cc=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=simona.vetter@ffwll.ch \
    --cc=skhan@linuxfoundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox