workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Jonathan Corbet <corbet@lwn.net>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	Kees Cook <kees@kernel.org>
Cc: Carlos Bilbao <carlos.bilbao.osdev@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	ksummit@lists.linux.dev
Subject: Re: [PATCH v2 2/2] Documentation: best practices for using Link trailers
Date: Wed, 26 Jun 2024 16:17:56 -0700	[thread overview]
Message-ID: <4709c2fa-081f-4307-bc9e-eef928255c08@infradead.org> (raw)
In-Reply-To: <87cyo3fgcb.fsf@trenco.lwn.net>



On 6/26/24 4:13 PM, Jonathan Corbet wrote:
> Konstantin Ryabitsev <konstantin@linuxfoundation.org> writes:
> 
>> On Fri, Jun 21, 2024 at 02:07:44PM GMT, Kees Cook wrote:
>>> On Wed, Jun 19, 2024 at 02:24:07PM -0400, Konstantin Ryabitsev wrote:
>>>> +   This URL should be used when referring to relevant mailing list
>>>> +   topics, related patch sets, or other notable discussion threads.
>>>> +   A convenient way to associate ``Link:`` trailers with the commit
>>>> +   message is to use markdown-like bracketed notation, for example::
>>>> ...
>>>> +     Link: https://lore.kernel.org/some-msgid@here # [1]
>>>> +     Link: https://bugzilla.example.org/bug/12345  # [2]
>>>
>>> Why are we adding the extra "# " characters? The vast majority of
>>> existing Link tags don't do this:
>>
>> That's just convention. In general, the hash separates the trailer from the
>> comment:
>>
>>     Trailer-name: actual-trailer-body # comment
>>
> 
> Did we ever come to a conclusion on this?  This one character seems to
> be the main source of disagreement in this series, I'm wondering if I
> should just apply it and let the painting continue thereafter...?

We have used '#' for ages for adding comments to by: tags.
I'm surprised that it's not documented.

-- 
~Randy

  reply	other threads:[~2024-06-26 23:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19 18:24 [PATCH v2 0/2] Documentation: update information for mailing lists Konstantin Ryabitsev
2024-06-19 18:24 ` [PATCH v2 1/2] Documentation: fix links to mailing list services Konstantin Ryabitsev
2024-06-19 18:24 ` [PATCH v2 2/2] Documentation: best practices for using Link trailers Konstantin Ryabitsev
2024-06-21 10:34   ` Michael S. Tsirkin
2024-06-21 21:07   ` Kees Cook
2024-06-21 21:37     ` Konstantin Ryabitsev
2024-06-26 23:13       ` Jonathan Corbet
2024-06-26 23:17         ` Randy Dunlap [this message]
2024-06-27  3:51           ` Thorsten Leemhuis
2024-06-27  4:24             ` Randy Dunlap
2024-06-28 14:52             ` Konstantin Ryabitsev
2024-06-28 18:32               ` Steven Rostedt
2024-06-22  4:27   ` Michael Ellerman
2024-06-22 14:40     ` Kees Cook
2024-06-22 15:15       ` Randy Dunlap
2024-06-22 20:13 ` [PATCH v2 0/2] Documentation: update information for mailing lists Carlos Bilbao
2024-07-02 20:47 ` Steven Rostedt
2024-07-03 23:04 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4709c2fa-081f-4307-bc9e-eef928255c08@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=carlos.bilbao.osdev@gmail.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kees@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=ksummit@lists.linux.dev \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox