From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BEFA258EFB for ; Tue, 25 Nov 2025 16:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764087118; cv=none; b=UpG30QTOOIZPi+MVdr7jXQECyK5rj/WJzRU6ogEZBlPuQvFmozjyRNvgWi8ZpPAREGL9+gaLx40GhlbMu8WWGpb7NnhXHOKcYNNdgu+OXtJYhBNDAB5z50mlUjfyJuPI5yx/X38RF8Vn3m/4A3jFGm9IlcDAAuKupElK2emEI5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764087118; c=relaxed/simple; bh=BuZrTAyq8hriBu1hSQ7Fw+Kj5Pru8BEFikgqu5lpwuo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=H7MkPHsqSPrRrb4BhaeAfRU3XiHLQJsv3BZUBQOCFKaCmk30NN+Nu7bHADyPPxwKtJXPujgPX4SKzAtJKERkf3fpcjPkuEbbJt068eNpPcbgzP2QsSK9LHr9ifrhaEwQCH6fHl1/6M1OPET6VNQlBp+2YV5qaK6K/BG+9Bx4SZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bwj3FjFX; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bwj3FjFX" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-29ba9249e9dso14638505ad.3 for ; Tue, 25 Nov 2025 08:11:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764087116; x=1764691916; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=BuZrTAyq8hriBu1hSQ7Fw+Kj5Pru8BEFikgqu5lpwuo=; b=Bwj3FjFXPs8a9wS4amr9YpCAspdsOrVG+yRJxZr2qr6loVDR6a3GJwV3TjG1K8ugjR vb5S+yxFAPW9Zvh0bJCcpUCMx5xrAICNUxgzAslfUCG8NtfxFr9nsLZOjTVIYCgGYgZo rflo4WKrMrdP8hxRbe1Zxu/c6+JkS5a2dcY/DXQePpvgEUIxNGObAKh3OzYb4SZRkHsj fmcQoA2cu7YcMftfOzTbsK/uPJzRYfI1r5V2nOApzvSWEnOmR6oVQ5vnx0Iqs37qvuGC /QjidajXjx81vY3bbI3KEsxuqnUS+NV4moyeLLXirYgr/FSVCHfJ6llaevGVx7cL19t5 XOfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764087116; x=1764691916; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BuZrTAyq8hriBu1hSQ7Fw+Kj5Pru8BEFikgqu5lpwuo=; b=WRoQLFK28+1QSlj7PRStOcCPdewMDxrEsHJoD2npTNaV8LEqvlZjdt5w/5n9zbC3Fj SS5jJOq7wgOXrzXRVTI8aUujyNS+Orut+ShWa74wjiRBnb8WI8iHSeCdApHLsa5Ae05T ASp8pxSuYgHMP2/1h92ZSVLKLRo4XVkOePR34MHk2WmPSVk9c4/HnyjNX7qpEzt7Iyjg pqIj93EFXOESFYWJbscD4YEfezSrM8pg25Cc+l1CXhOzmjJZSFeu/n/ZeUFnJrgzIY+d 1xQCKr/MlO2wuRPZ44HTAG6bye/2HOXXzHCegG1vykZoB7K502i3mw1eteDN/r6v96UD XvAQ== X-Gm-Message-State: AOJu0Yye2jp4tH4igWMvc8gOSKvYEc9OS+vfcHFhmmPcQS4vmAPN7S6X tx0aPJ7ZfXCByNAhL1fkzR4OY0qSUq26rQt9PnhNIT1yEjwqLaXAxGaG X-Gm-Gg: ASbGnct37kLzRXdAwCKAv4Bxx1ibKGDvNgmumqviYQZKx6xeLnGkDPz1vDHeX2/vxZq eNtJJInlMVBCLTMHCIRPxKNkjZLq3MeKk5WpqomcTaj1UVmytLT32jySPyIMOMMfk8iCijtfq6f JhPp26qr4FIlV1WCo6TkfXg2XOHVQ8Zal1oqKTa1Zr0bH57zuE5NNxq75meWMAohihKy8pcZEM9 xQBWuDiPC/MV9UzBphwspDRSEMW2I10sMjmYFuoHtzKvaVkDvIf00wgs22QsMJjYygj3aEYMvoa +CXWuImvshqVPZjAW1TjKmhVJHGX97dYV0beOOe/nUQpTp4tZANW2pNocNKiDgG8xlc5mIAOjUa FodG+UseZja4rmakOp5LdP9nodvxLp6FtXlDob21l2BAPaiRLrjszgkPjZzPTHuOLY2QQzgomGq BQZMSBfrQ37+T6wTJvYKCnMmGAEb/FDjMvFNW6W+yIKDcoOA0XMJBPzUCMvkVC3a+4uQ== X-Google-Smtp-Source: AGHT+IEWXlqC42ig+eSywfDNQtEHaCjz4s5p+M3v/+IuUcUyKtCw+yNJ/t4+Y0x5LwSh4SzxUB/PrQ== X-Received: by 2002:a17:90b:384f:b0:340:ac7c:6387 with SMTP id 98e67ed59e1d1-34733e2d4a5mr19048369a91.7.1764087116050; Tue, 25 Nov 2025 08:11:56 -0800 (PST) Received: from ?IPv6:2401:4900:8fce:eb65:99e9:53c:32e6:4996? ([2401:4900:8fce:eb65:99e9:53c:32e6:4996]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3475ff9fed2sm1369564a91.6.2025.11.25.08.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 08:11:55 -0800 (PST) Message-ID: <43f43063b81da41b693d5eb8178d5c55ebaaa168.camel@gmail.com> Subject: Re: [PATCH RESEND v6] checkpatch: add uninitialized pointer with __free attribute check From: ally heev To: Krzysztof Kozlowski , Dwaipayan Ray , Lukas Bulwahn , Joe Perches , Jonathan Corbet , Andy Whitcroft Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter , David Hunter , Shuah Khan , Viresh Kumar , Nishanth Menon , Stephen Boyd , linux-pm , dan.j.williams@intel.com, Geert Uytterhoeven , James Bottomley Date: Tue, 25 Nov 2025 21:41:47 +0530 In-Reply-To: <58393a1f-272b-41be-9ebd-ae03678cb738@kernel.org> References: <20251125-aheev-checkpatch-uninitialized-free-v6-1-70e8bb1e9175@gmail.com> <58393a1f-272b-41be-9ebd-ae03678cb738@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-11-25 at 16:09 +0100, Krzysztof Kozlowski wrote: > On 25/11/2025 14:32, Ally Heev wrote: > > uninitialized pointers with __free attribute can cause undefined > > behavior as the memory randomly assigned to the pointer is freed > > automatically when the pointer goes out of scope. > > add check in checkpatch to detect such issues. > >=20 > > Suggested-by: Dan Carpenter > > Link: https://lore.kernel.org/all/8a4c0b43-cf63-400d-b33d-d9c447b7e0b9@= suswa.mountain/ > > Link: https://lore.kernel.org/all/58fd478f408a34b578ee8d949c5c4b4da4d4f= 41d.camel@HansenPartnership.com/ > > Acked-by: Dan Williams > > Signed-off-by: Ally Heev >=20 >=20 >
> This is a friendly reminder during the review process. >=20 > It looks like you received a tag and forgot to add it. >=20 > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions > of patchset, under or above your Signed-off-by tag, unless patch changed > significantly (e.g. new properties added to the DT bindings). Tag is > "received", when provided in a message replied to you on the mailing > list. Tools like b4 can help here. However, there's no need to repost > patches *only* to add the tags. The upstream maintainer will do that for > tags received on the version they apply. >=20 > Please read: > https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/s= ubmitting-patches.rst#L577 >=20 > If a tag was not added on purpose, please state why and what changed. >
>=20 >=20 > Best regards, > Krzysztof Oopsie. I should have sent a new version instead of resending a failed one. I have updated the `UNINITIALIZED_PTR_WITH_FREE` error description in the checkpatch doc as outlined in v6 changelog, so, didn't add a Reviewed-by tag For some reason gmail blocked me from sending v6 to everyone in the patch except me. b4 thought it successfully sent the patch and incremented the version number. So, I had to resend it Thanks, Ally