Re: [PATCH net-next] docs: netdev: document AI-assisted review tooling

[Fernando Fernandez Mancera <fmancera@suse.de>]

On 4/6/26 9:40 PM, Nicolai Buchwitz wrote:
> Add a section about Sashiko, the Linux Foundation's open-source
> AI review system for kernel patches. Contributors can check review
> feedback on the Sashiko website and address findings proactively,
> reducing the need for maintainers to relay the same questions.
> 
> Also point to the local review tooling at netdev-ai.bots.linux.dev
> for contributors who want to run AI reviews before submitting.
> 
> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
> ---
> Sashiko [1] reviews are already being used on the list (e.g. [2])
> but there's no mention of them in the netdev docs. Add a section
> so contributors know they can check and respond to AI review
> feedback directly.
> 
> Based on Jakub's reviewer guidance patch [3].
> 
> [1] https://sashiko.dev/
> [2] https://lore.kernel.org/all/20260324024235.929875-1-kuba@kernel.org/
> [3] https://lore.kernel.org/all/20260406175334.3153451-1-kuba@kernel.org/
> ---
>   Documentation/process/maintainer-netdev.rst | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
> index bda93b459a0533fa1adfd11b756a4f47d1dbaa22..27296afb05d3828a350b4ed5c16907672db9785d 100644
> --- a/Documentation/process/maintainer-netdev.rst
> +++ b/Documentation/process/maintainer-netdev.rst
> @@ -559,6 +559,19 @@ Reviewers are highly encouraged to do more in-depth review of submissions
>   and not focus exclusively on process issues, trivial or subjective
>   matters like code formatting, tags etc.
>   
> +AI-assisted review
> +~~~~~~~~~~~~~~~~~~
> +
> +Patches posted to netdev are automatically reviewed by the Sashiko
> +AI review system (https://sashiko.dev/). Results are posted publicly
> +on the website. 

Hi Nicolai,

maybe I am missing something but [2] isn't from sashiko.dev but from 
netdev AI CI instead. See: 
https://netdev-ai.bots.linux.dev/ai-review.html?id=0b114a22-9aab-4265-8bfc-ea1b5bca5514

The documentation mentioned for running the AI locally is correctly 
related to netdev AI bot.

I think it would be useful to document that AI reviews are happening but 
mixing AI bots might confuse people.

> Check for findings on your submissions and address
> +valid ones before a maintainer has to relay the same questions.
> +

I wonder what would be the consequences for this. If less experienced 
submitters are expected to address issues pointed out by AI bots they 
might work on something that isn't valid. AFAIU, the AI output is only 
forwarded to the submitter after a maintainer reviewed it and believes 
it makes sense.

Thanks,
Fernando.

> +You can also run AI reviews locally before submitting. Instructions
> +and tooling are available at:
> +
> +  https://netdev-ai.bots.linux.dev/ai-local.html
> +
>   Testimonials / feedback
>   -----------------------
>