workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dragan Simic <dsimic@manjaro.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com,
	lukas.bulwahn@gmail.com, workflows@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	wens@csie.org
Subject: Re: [PATCH v2 0/3] Make Helped-by tag supported
Date: Sat, 09 Nov 2024 04:10:11 +0100	[thread overview]
Message-ID: <28c0a0ecc2e2880e4cb98449767e2842@manjaro.org> (raw)
In-Reply-To: <672e628111eb0_10bc629436@dwillia2-xfh.jf.intel.com.notmuch>

Hello Dan,

On 2024-11-08 20:12, Dan Williams wrote:
> Dragan Simic wrote:
>> I'm fully aware that we may be reluctant to supporting additional 
>> tags,
>> because we may then end up with a whole bunch of strange tags that 
>> might
>> be a bit hard to understand and use properly, but I think that adding
>> Helped-by to the supported tag list may actually be a good thing to 
>> do.
>> As described above, Helped-by fits very well between the Suggested-by
>> tag and the Co-developed-by + Signed-off-by pair of tags, and I think
>> that providing the right level of attribution may be beneficial.
> 
> Patch attribution is separate from giving thanks. I would much rather
> someone take the time to say "Thanks" in the changelog with some
> supporting text rather than boil down all the myriad ways to be 
> thankful
> into a generic tag. "git log --grep=Thanks" often yields valuable
> details, beyond just attribution, on how people have helped each other
> develop this global project of ours. If the introduction of Helped-by
> would replace even one authentic "Thank you" note with a generic tag
> then it is a net loss for the community.

I do agree that writing "Thanks John for helping with..." in a patch
description would be nice, but unfortunately I've seen multiple times
that people don't enjoy writing their patch descriptions at all, and
just want to "get them out the door" as quickly as possible.

With that in mind, making Helped-by tags supported would allow such
people to at least quickly mention someone they're thankful to, which
actually wouldn't prevent anyone from saying the same more verbosely
in a patch description.

  reply	other threads:[~2024-11-09  3:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06  6:28 Dragan Simic
2024-11-06  6:28 ` [PATCH v2 1/3] checkpatch: " Dragan Simic
2024-11-06  6:28 ` [PATCH v2 2/3] docs: submitting-patches: Reflow one short paragraph Dragan Simic
2024-11-06  6:28 ` [PATCH v2 3/3] docs: submitting-patches: Describe the use of Helped-by tag Dragan Simic
2024-11-06  6:47   ` Dragan Simic
2024-11-06 14:28 ` [PATCH v2 0/3] Make Helped-by tag supported Jonathan Corbet
2024-11-07 14:09   ` Dragan Simic
2024-11-08 19:12     ` Dan Williams
2024-11-09  3:10       ` Dragan Simic [this message]
2024-12-02 15:00         ` Dragan Simic
2024-12-02 17:11           ` Matthew Wilcox
2024-12-04  0:56             ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28c0a0ecc2e2880e4cb98449767e2842@manjaro.org \
    --to=dsimic@manjaro.org \
    --cc=apw@canonical.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=wens@csie.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox