From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: joe@perches.com, geert@linux-m68k.org, netdev@vger.kernel.org,
workflows@vger.kernel.org, mario.limonciello@amd.com
Subject: Re: [PATCH] scripts: checkpatch: steer people away from using file paths
Date: Tue, 25 Jul 2023 18:57:43 +0200 [thread overview]
Message-ID: <22eb89c5-9c94-6498-4079-b3b732aacfe0@kernel.org> (raw)
In-Reply-To: <20230725155926.2775416-1-kuba@kernel.org>
On 25/07/2023 17:59, Jakub Kicinski wrote:
> We repeatedly see noobs misuse get_maintainer by running it on
> the file paths rather than the patchfile. This leads to authors
> of changes (quoted commits and commits under Fixes) not getting
> CCed. These are usually the best reviewers!
>
> The file option should really not be used by noobs, unless
> they are just trying to find a maintainer to manually contact.
>
> Print a warning when someone tries to use -f and remove
> the "auto-guessing" of file paths.
>
> This script may break people's "scripts on top of get_maintainer"
> if they are using -f... but that's the point.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> This is what I had in mind.
"Anything that can go wrong will go wrong."
https://en.wikipedia.org/wiki/Murphy%27s_law
Therefore:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-25 16:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230721062617.9810-1-boon.khai.ng@intel.com>
[not found] ` <20230721062617.9810-2-boon.khai.ng@intel.com>
[not found] ` <e552cea3-abbb-93e3-4167-aebe979aac6b@kernel.org>
[not found] ` <DM8PR11MB5751EAB220E28AECF6153522C13FA@DM8PR11MB5751.namprd11.prod.outlook.com>
[not found] ` <8e2f9c5f-6249-4325-58b2-a14549eb105d@kernel.org>
[not found] ` <20230721185557.199fb5b8@kernel.org>
[not found] ` <c690776ce6fd247c2b2aeb805744d5779b6293ab.camel@perches.com>
2023-07-25 1:04 ` [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload Jakub Kicinski
2023-07-25 3:53 ` Joe Perches
2023-07-25 7:33 ` Geert Uytterhoeven
2023-07-25 13:19 ` Mario Limonciello
2023-07-25 13:43 ` Joe Perches
2023-07-25 14:37 ` Krzysztof Kozlowski
2023-07-25 15:59 ` [PATCH] scripts: checkpatch: steer people away from using file paths Jakub Kicinski
2023-07-25 16:53 ` Greg KH
2023-07-25 17:10 ` Jakub Kicinski
2023-07-25 17:25 ` Greg KH
2023-07-25 19:52 ` Jakub Kicinski
2023-07-25 21:01 ` Joe Perches
2023-07-25 16:57 ` Krzysztof Kozlowski [this message]
2023-07-25 21:18 ` Joe Perches
2023-07-25 22:15 ` Jakub Kicinski
2023-07-26 6:28 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22eb89c5-9c94-6498-4079-b3b732aacfe0@kernel.org \
--to=krzk@kernel.org \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=mario.limonciello@amd.com \
--cc=netdev@vger.kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox