workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link
@ 2026-02-05 11:55 Amitabh Srivastava
  2026-02-05 13:23 ` Geert Uytterhoeven
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Amitabh Srivastava @ 2026-02-05 11:55 UTC (permalink / raw)
  To: corbet; +Cc: workflows, linux-doc, linux-kernel, Amitabh Srivastava

Update http link to the documentation about how to add a kernel.org UID to
the maintainer's key. Add missing SPDX-License-Identifier to fix a
checkpatch warning.

Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
---
 Documentation/process/maintainer-pgp-guide.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
index b6919bf606c3..1e4d885dc784 100644
--- a/Documentation/process/maintainer-pgp-guide.rst
+++ b/Documentation/process/maintainer-pgp-guide.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: GPL-2.0
+
 .. _pgpguide:
 
 ===========================
@@ -864,7 +866,7 @@ don't already have them)::
 If you have a kernel.org account, then you should `add the kernel.org
 UID to your key`_ to make WKD more useful to other kernel developers.
 
-.. _`add the kernel.org UID to your key`: https://korg.wiki.kernel.org/userdoc/mail#adding_a_kernelorg_uid_to_your_pgp_key
+.. _`add the kernel.org UID to your key`: https://korg.docs.kernel.org/mail.html#adding-a-kernel-org-uid-to-your-pgp-key
 
 Web of Trust (WOT) vs. Trust on First Use (TOFU)
 ------------------------------------------------
-- 
2.51.0


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link
  2026-02-05 11:55 [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link Amitabh Srivastava
@ 2026-02-05 13:23 ` Geert Uytterhoeven
  2026-02-05 14:14   ` Amitabh
  2026-02-05 14:49 ` Jonathan Corbet
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2026-02-05 13:23 UTC (permalink / raw)
  To: Amitabh Srivastava; +Cc: corbet, workflows, linux-doc, linux-kernel

Hi Amitabh,

Thanks for your patch!

On Thu, 5 Feb 2026 at 13:09, Amitabh Srivastava <amitabh@amidevlab.com> wrote:
> Update http link to the documentation about how to add a kernel.org UID to
> the maintainer's key. Add missing SPDX-License-Identifier to fix a
> checkpatch warning.

The first sentence states the obvious, but does not explain the
rationale behind this change.  Why should it be changed?  Both the
old and the new URL work.

> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>

> --- a/Documentation/process/maintainer-pgp-guide.rst
> +++ b/Documentation/process/maintainer-pgp-guide.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  .. _pgpguide:
>
>  ===========================
> @@ -864,7 +866,7 @@ don't already have them)::
>  If you have a kernel.org account, then you should `add the kernel.org
>  UID to your key`_ to make WKD more useful to other kernel developers.
>
> -.. _`add the kernel.org UID to your key`: https://korg.wiki.kernel.org/userdoc/mail#adding_a_kernelorg_uid_to_your_pgp_key
> +.. _`add the kernel.org UID to your key`: https://korg.docs.kernel.org/mail.html#adding-a-kernel-org-uid-to-your-pgp-key
>
>  Web of Trust (WOT) vs. Trust on First Use (TOFU)
>  ------------------------------------------------

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link
  2026-02-05 13:23 ` Geert Uytterhoeven
@ 2026-02-05 14:14   ` Amitabh
  0 siblings, 0 replies; 11+ messages in thread
From: Amitabh @ 2026-02-05 14:14 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: corbet, workflows, linux-doc, linux-kernel

Hi Geert,

Hope this clarifies.

> On 5 Feb 2026, at 6:53 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> 
> Hi Amitabh,
> 
> Thanks for your patch!
> 
> On Thu, 5 Feb 2026 at 13:09, Amitabh Srivastava <amitabh@amidevlab.com> wrote:
>> Update http link to the documentation about how to add a kernel.org UID to
>> the maintainer's key. Add missing SPDX-License-Identifier to fix a
>> checkpatch warning.
> 
> > The first sentence states the obvious, but does not explain the
> > rationale behind this change.  Why should it be changed?  Both the
> > old and the new URL work.

> The old URL no longer points to the correct page having mentioned information.
> [Old URL]: Simply redirects to 'https://korg.docs.kernel.org/', which doesn't have any information on how to add the kernel.org UID to your PGP key.
> [New URL]: Precisely opens the respective page at the anchor for the respective section 'Adding a kernel.org UID to your PGP key'.

>> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
> 
>> --- a/Documentation/process/maintainer-pgp-guide.rst
>> +++ b/Documentation/process/maintainer-pgp-guide.rst
>> @@ -1,3 +1,5 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> .. _pgpguide:
>> 
>> ===========================
>> @@ -864,7 +866,7 @@ don't already have them)::
>> If you have a kernel.org account, then you should `add the kernel.org
>> UID to your key`_ to make WKD more useful to other kernel developers.
>> 
>> -.. _`add the kernel.org UID to your key`: https://korg.wiki.kernel.org/userdoc/mail#adding_a_kernelorg_uid_to_your_pgp_key
>> +.. _`add the kernel.org UID to your key`: https://korg.docs.kernel.org/mail.html#adding-a-kernel-org-uid-to-your-pgp-key
>> 
>> Web of Trust (WOT) vs. Trust on First Use (TOFU)
>> ------------------------------------------------
> 
> Gr{oetje,eeting}s,
> 
>                        Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                -- Linus TorvaldsThanks

> Regards

> Amitabh

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link
  2026-02-05 11:55 [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link Amitabh Srivastava
  2026-02-05 13:23 ` Geert Uytterhoeven
@ 2026-02-05 14:49 ` Jonathan Corbet
  2026-02-05 15:15   ` Amitabh
  2026-02-06 14:38 ` Konstantin Ryabitsev
  2026-02-09 19:51 ` Jonathan Corbet
  3 siblings, 1 reply; 11+ messages in thread
From: Jonathan Corbet @ 2026-02-05 14:49 UTC (permalink / raw)
  To: Amitabh Srivastava; +Cc: workflows, linux-doc, linux-kernel, Amitabh Srivastava

Amitabh Srivastava <amitabh@amidevlab.com> writes:

> Update http link to the documentation about how to add a kernel.org UID to
> the maintainer's key. Add missing SPDX-License-Identifier to fix a
> checkpatch warning.
>
> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
> ---
>  Documentation/process/maintainer-pgp-guide.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
> index b6919bf606c3..1e4d885dc784 100644
> --- a/Documentation/process/maintainer-pgp-guide.rst
> +++ b/Documentation/process/maintainer-pgp-guide.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +

Do you know that was the intended license for this file?  We need to be
careful about putting license declarations on other people's work.

Thanks,

jon

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link
  2026-02-05 14:49 ` Jonathan Corbet
@ 2026-02-05 15:15   ` Amitabh
  2026-02-05 15:30     ` Jonathan Corbet
  0 siblings, 1 reply; 11+ messages in thread
From: Amitabh @ 2026-02-05 15:15 UTC (permalink / raw)
  To: Jonathan Corbet; +Cc: workflows, linux-doc, linux-kernel

Hi Jon,

> On 5 Feb 2026, at 8:19 PM, Jonathan Corbet <corbet@lwn.net> wrote:
> 
> Amitabh Srivastava <amitabh@amidevlab.com> writes:
> 
>> Update http link to the documentation about how to add a kernel.org UID to
>> the maintainer's key. Add missing SPDX-License-Identifier to fix a
>> checkpatch warning.
>> 
>> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
>> ---
>> Documentation/process/maintainer-pgp-guide.rst | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
>> index b6919bf606c3..1e4d885dc784 100644
>> --- a/Documentation/process/maintainer-pgp-guide.rst
>> +++ b/Documentation/process/maintainer-pgp-guide.rst
>> @@ -1,3 +1,5 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
> 
> Do you know that was the intended license for this file?  We need to be
> careful about putting license declarations on other people's work.
> 
Yes, The Linux kernel documentation is typically licensed under GPL-2.0.
Other files in the directory contain the same 'SPDX-License-Identifier' as well.
However, I have added this just to satisfy checkpatch.pl requirement, which
checks for missing license information in documentation files. Let me know if
you think otherwise.

> Thanks,
> 
> jon


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link
  2026-02-05 15:15   ` Amitabh
@ 2026-02-05 15:30     ` Jonathan Corbet
       [not found]       ` <3AB51D59-A054-4847-91CD-DFF3A2EB5F04@amidevlab.com>
  0 siblings, 1 reply; 11+ messages in thread
From: Jonathan Corbet @ 2026-02-05 15:30 UTC (permalink / raw)
  To: Amitabh; +Cc: workflows, linux-doc, linux-kernel

Amitabh <amitabh@amidevlab.com> writes:

> Hi Jon,
>
>> On 5 Feb 2026, at 8:19 PM, Jonathan Corbet <corbet@lwn.net> wrote:
>> 
>> Amitabh Srivastava <amitabh@amidevlab.com> writes:
>> 
>>> Update http link to the documentation about how to add a kernel.org UID to
>>> the maintainer's key. Add missing SPDX-License-Identifier to fix a
>>> checkpatch warning.
>>> 
>>> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
>>> ---
>>> Documentation/process/maintainer-pgp-guide.rst | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
>>> index b6919bf606c3..1e4d885dc784 100644
>>> --- a/Documentation/process/maintainer-pgp-guide.rst
>>> +++ b/Documentation/process/maintainer-pgp-guide.rst
>>> @@ -1,3 +1,5 @@
>>> +.. SPDX-License-Identifier: GPL-2.0
>>> +
>> 
>> Do you know that was the intended license for this file?  We need to be
>> careful about putting license declarations on other people's work.
>> 
> Yes, The Linux kernel documentation is typically licensed under GPL-2.0.

I am aware of kernel documentation practices :)  "Typically licensed"
does not tell you what any individual contributor intended, though.
*Probably* that tag is OK, but you should really consult with the
original author of that page to ask what their intent was.

> Other files in the directory contain the same 'SPDX-License-Identifier' as well.
> However, I have added this just to satisfy checkpatch.pl requirement, which
> checks for missing license information in documentation files. Let me know if
> you think otherwise.

Checkpatch makes suggestions, not requirements.  All files in the kernel
should have SPDX lines, but they need to be the correct ones, not just
somebody's guess.

Thanks,

jon

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link
       [not found]       ` <3AB51D59-A054-4847-91CD-DFF3A2EB5F04@amidevlab.com>
@ 2026-02-06 14:20         ` Konstantin Ryabitsev
  0 siblings, 0 replies; 11+ messages in thread
From: Konstantin Ryabitsev @ 2026-02-06 14:20 UTC (permalink / raw)
  To: Amitabh; +Cc: Jonathan Corbet, workflows, linux-doc, linux-kernel

On Fri, Feb 06, 2026 at 12:02:00AM +0530, Amitabh wrote:
> > I am aware of kernel documentation practices :)  "Typically licensed"
> > does not tell you what any individual contributor intended, though.
> > *Probably* that tag is OK, but you should really consult with the
> > original author of that page to ask what their intent was.
> 
> You are absolutely correct. In fact, the original author, Konstantin Ryabitsev,
> (in TO here) responded to my v1 patch in the affirmative regarding the changes.
> (https://lore.kernel.org/all/177006480695.901069.1641199463436529014@lemur/)

Yes, that matches the intended license.

-K

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link
  2026-02-05 11:55 [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link Amitabh Srivastava
  2026-02-05 13:23 ` Geert Uytterhoeven
  2026-02-05 14:49 ` Jonathan Corbet
@ 2026-02-06 14:38 ` Konstantin Ryabitsev
  2026-02-06 16:04   ` Jonathan Corbet
  2026-02-09 19:51 ` Jonathan Corbet
  3 siblings, 1 reply; 11+ messages in thread
From: Konstantin Ryabitsev @ 2026-02-06 14:38 UTC (permalink / raw)
  To: Amitabh Srivastava, corbet; +Cc: workflows, linux-doc, linux-kernel

On Thu, Feb 5, 2026, at 06:55, Amitabh Srivastava wrote:
> Update http link to the documentation about how to add a kernel.org UID to
> the maintainer's key. Add missing SPDX-License-Identifier to fix a
> checkpatch warning.

No objections from me, but please check with other reviewers if they want another revision.

Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

-K

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link
  2026-02-06 14:38 ` Konstantin Ryabitsev
@ 2026-02-06 16:04   ` Jonathan Corbet
  2026-02-06 20:43     ` Amitabh
  0 siblings, 1 reply; 11+ messages in thread
From: Jonathan Corbet @ 2026-02-06 16:04 UTC (permalink / raw)
  To: Konstantin Ryabitsev, Amitabh Srivastava
  Cc: workflows, linux-doc, linux-kernel

"Konstantin Ryabitsev" <mricon@kernel.org> writes:

> On Thu, Feb 5, 2026, at 06:55, Amitabh Srivastava wrote:
>> Update http link to the documentation about how to add a kernel.org UID to
>> the maintainer's key. Add missing SPDX-License-Identifier to fix a
>> checkpatch warning.
>
> No objections from me, but please check with other reviewers if they want another revision.
>
> Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

I think we've probably done enough rounds on this one :)

Thanks,

jon

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link
  2026-02-06 16:04   ` Jonathan Corbet
@ 2026-02-06 20:43     ` Amitabh
  0 siblings, 0 replies; 11+ messages in thread
From: Amitabh @ 2026-02-06 20:43 UTC (permalink / raw)
  To: Jonathan Corbet; +Cc: Konstantin Ryabitsev, workflows, linux-doc, linux-kernel

Hi Jon,

Hope my patch gets accepted for commit.


> On 6 Feb 2026, at 9:34 PM, Jonathan Corbet <corbet@lwn.net> wrote:
> 
> "Konstantin Ryabitsev" <mricon@kernel.org> writes:
> 
>> On Thu, Feb 5, 2026, at 06:55, Amitabh Srivastava wrote:
>>> Update http link to the documentation about how to add a kernel.org UID to
>>> the maintainer's key. Add missing SPDX-License-Identifier to fix a
>>> checkpatch warning.
>> 
>> No objections from me, but please check with other reviewers if they want another revision.
>> 
>> Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
> 
> I think we've probably done enough rounds on this one :)
> 
> Thanks,
> 
> Jon

Regards
Amitabh


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link
  2026-02-05 11:55 [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link Amitabh Srivastava
                   ` (2 preceding siblings ...)
  2026-02-06 14:38 ` Konstantin Ryabitsev
@ 2026-02-09 19:51 ` Jonathan Corbet
  3 siblings, 0 replies; 11+ messages in thread
From: Jonathan Corbet @ 2026-02-09 19:51 UTC (permalink / raw)
  To: Amitabh Srivastava; +Cc: workflows, linux-doc, linux-kernel, Amitabh Srivastava

Amitabh Srivastava <amitabh@amidevlab.com> writes:

> Update http link to the documentation about how to add a kernel.org UID to
> the maintainer's key. Add missing SPDX-License-Identifier to fix a
> checkpatch warning.
>
> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
> ---
>  Documentation/process/maintainer-pgp-guide.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
> index b6919bf606c3..1e4d885dc784 100644
> --- a/Documentation/process/maintainer-pgp-guide.rst
> +++ b/Documentation/process/maintainer-pgp-guide.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  .. _pgpguide:
>  
>  ===========================
> @@ -864,7 +866,7 @@ don't already have them)::
>  If you have a kernel.org account, then you should `add the kernel.org
>  UID to your key`_ to make WKD more useful to other kernel developers.
>  
> -.. _`add the kernel.org UID to your key`: https://korg.wiki.kernel.org/userdoc/mail#adding_a_kernelorg_uid_to_your_pgp_key
> +.. _`add the kernel.org UID to your key`: https://korg.docs.kernel.org/mail.html#adding-a-kernel-org-uid-to-your-pgp-key
>  

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2026-02-09 19:51 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-05 11:55 [PATCH v3] docs: process: maintainer-pgp-guide: update kernel.org docs link Amitabh Srivastava
2026-02-05 13:23 ` Geert Uytterhoeven
2026-02-05 14:14   ` Amitabh
2026-02-05 14:49 ` Jonathan Corbet
2026-02-05 15:15   ` Amitabh
2026-02-05 15:30     ` Jonathan Corbet
     [not found]       ` <3AB51D59-A054-4847-91CD-DFF3A2EB5F04@amidevlab.com>
2026-02-06 14:20         ` Konstantin Ryabitsev
2026-02-06 14:38 ` Konstantin Ryabitsev
2026-02-06 16:04   ` Jonathan Corbet
2026-02-06 20:43     ` Amitabh
2026-02-09 19:51 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox