From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alejandro Colomar <alx@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Yeking@red54.com, kuba@kernel.org,
Jonathan Corbet <corbet@lwn.net>, Theodore Ts'o <tytso@mit.edu>,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, tech-board-discuss@lists.linux.dev,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] Add short author date to Fixes tag
Date: Wed, 25 Feb 2026 10:00:06 -0800 [thread overview]
Message-ID: <2026022531-tightness-rare-6a14@gregkh> (raw)
In-Reply-To: <aZ4_sBIy8rOUL59Q@devuan>
On Wed, Feb 25, 2026 at 01:56:02AM +0100, Alejandro Colomar wrote:
> [Message-ID: <2025011032-gargle-showing-7500@gregkh>]
> Greg wrote (Fri, 10 Jan 2025 13:32:22 +0100):
> > Please no, you will break all of our tooling and scripts that parse
> > these types of fields. The git commit id and commit header is all we
> > need to properly determine this type of information, no need to add a
> > date in here at all.
> >
> [...]
> >
> > So I don't think you need to add a date here. Dates also really do not
> > mean much with commits, what matters is what release a commit is in, not
> > when it was originally made. We have commits that take years to show up
> > in a release, so if you only look at a date, you will be mistaken many
> > times as it's not showing what came before what many times (i.e. we
> > apply commits out-of-date-order all the time.)
>
> As I said above, I agree that the commit date is the right choice.
> Author dates can be out-of-date-order by years. Commit dates are
> necessarily in order, though.
Commit date also doesn't matter. If I commit a fix to one of my
branches today, but Linus pulls it in in 2 years from now, what would
that date really show to anyone?
Again, all that matters is when a commit is in a release, and for that
you walk the tree/graph to determine it. Please don't consider changing
the format of our commit identification logic as we have tools that
parse and handle what we have today, and all would be changed if we were
to change it.
Especially when it doesn't even provide any specific value that I can
see, if you want that info, just get it directly from git after looking
it up.
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-25 18:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 0:56 Alejandro Colomar
2026-02-25 0:57 ` Alejandro Colomar
2026-02-25 18:00 ` Greg Kroah-Hartman [this message]
2026-02-25 18:20 ` Alejandro Colomar
2026-02-25 19:47 ` James Bottomley
2026-02-25 21:23 ` Greg Kroah-Hartman
2026-02-25 21:45 ` Alejandro Colomar
2026-02-25 22:35 ` Theodore Tso
2026-02-25 23:27 ` Sasha Levin
2026-02-25 23:46 ` Greg Kroah-Hartman
2026-02-26 0:20 ` Alejandro Colomar
2026-02-25 20:08 ` Sasha Levin
2026-02-26 0:08 ` Steven Rostedt
[not found] <tencent_6CF6E720909156A227D23AE8CFE4F9BA5D05@qq.com>
2025-01-10 12:20 ` Yeking
2025-01-10 12:32 ` Greg Kroah-Hartman
2025-01-10 13:03 ` Steven Rostedt
2025-01-11 0:21 ` Jacob Keller
2025-01-11 5:48 ` Greg Kroah-Hartman
2025-01-11 17:09 ` Steven Rostedt
2025-01-12 10:54 ` Geert Uytterhoeven
2025-01-13 14:51 ` Steven Rostedt
2025-01-13 15:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022531-tightness-rare-6a14@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Yeking@red54.com \
--cc=akpm@linux-foundation.org \
--cc=alx@kernel.org \
--cc=andrew@lunn.ch \
--cc=apw@canonical.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jacob.e.keller@intel.com \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=tech-board-discuss@lists.linux.dev \
--cc=tytso@mit.edu \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox