workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] docs: maintainer-pgp-guide.rst: updated kernel.org link
@ 2026-02-03  4:59 Amitabh Srivastava
  2026-02-03 14:48 ` Konstantin Ryabitsev
  0 siblings, 1 reply; 2+ messages in thread
From: Amitabh Srivastava @ 2026-02-03  4:59 UTC (permalink / raw)
  To: corbet
  Cc: workflows, linux-doc, linux-kernel, Amitabh Srivastava,
	Konstantin Ryabitsev

docs: process: maintainer-pgp-guide.rst: updated the http link for
'add the kernel.org UID to your key'. Added SPDX-License-Identifier
to fix checkpatch.pl warning. Tested kernel using qemu-system-aarch64
with busybox inside a multipass ubuntu VM on macos.

Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
---
 Documentation/process/maintainer-pgp-guide.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
index b6919bf606c3..1e4d885dc784 100644
--- a/Documentation/process/maintainer-pgp-guide.rst
+++ b/Documentation/process/maintainer-pgp-guide.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: GPL-2.0
+
 .. _pgpguide:
 
 ===========================
@@ -864,7 +866,7 @@ don't already have them)::
 If you have a kernel.org account, then you should `add the kernel.org
 UID to your key`_ to make WKD more useful to other kernel developers.
 
-.. _`add the kernel.org UID to your key`: https://korg.wiki.kernel.org/userdoc/mail#adding_a_kernelorg_uid_to_your_pgp_key
+.. _`add the kernel.org UID to your key`: https://korg.docs.kernel.org/mail.html#adding-a-kernel-org-uid-to-your-pgp-key
 
 Web of Trust (WOT) vs. Trust on First Use (TOFU)
 ------------------------------------------------
-- 
2.51.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] docs: maintainer-pgp-guide.rst: updated kernel.org link
  2026-02-03  4:59 [PATCH v2] docs: maintainer-pgp-guide.rst: updated kernel.org link Amitabh Srivastava
@ 2026-02-03 14:48 ` Konstantin Ryabitsev
  0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Ryabitsev @ 2026-02-03 14:48 UTC (permalink / raw)
  To: Amitabh Srivastava; +Cc: corbet, workflows, linux-doc, linux-kernel

On Tue, Feb 03, 2026 at 10:29:48AM +0530, Amitabh Srivastava wrote:
> docs: process: maintainer-pgp-guide.rst: updated the http link for

I missed this the last time, but you don't need to duplicate the "docs:
process:..." line here.

> 'add the kernel.org UID to your key'. Added SPDX-License-Identifier
> to fix checkpatch.pl warning. Tested kernel using qemu-system-aarch64

You don't need to mention how you tested it (great that you did, but it
doesn't need to be in the commit).

> with busybox inside a multipass ubuntu VM on macos.

I suggest that your submission should look like this:

    Subject: docs: process: maintainer-pgp-guide: update kernel.org docs link

    Update http link to the documentation about how to add a kernel.org UID to
    the maintainer's key. Add missing SPDX-License-Identifier to fix a
    checkpatch warning.

    Signed-off-by: ...

This has the following improvements:

- removes duplicate info that is already in the subject
- uses imperative mood that is required for commits (update vs updated)
  see: https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
> Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

You shouldn't do this -- I didn't actually reply with  a "Reviewed-by"
trailer. These trailers are given by the reviewer to indicate "I have reviewed
this and didn't find any problems with the patch. You should only add trailers
that you have actually received from reviewers.

Please send a v3 with these fixes and that should earn you a "Reviewed-by."

Best regards,
-- 
KR

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-03 14:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-03  4:59 [PATCH v2] docs: maintainer-pgp-guide.rst: updated kernel.org link Amitabh Srivastava
2026-02-03 14:48 ` Konstantin Ryabitsev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox