workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Amitabh Srivastava <amitabh@amidevlab.com>
Cc: corbet@lwn.net, workflows@vger.kernel.org,
	linux-doc@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: maintainer-pgp-guide.rst: updated kernel.org link
Date: Tue, 3 Feb 2026 09:48:22 -0500	[thread overview]
Message-ID: <20260203-spicy-terrestrial-jaguarundi-701efd@lemur> (raw)
In-Reply-To: <20260203050020.27792-1-amitabh@amidevlab.com>

On Tue, Feb 03, 2026 at 10:29:48AM +0530, Amitabh Srivastava wrote:
> docs: process: maintainer-pgp-guide.rst: updated the http link for

I missed this the last time, but you don't need to duplicate the "docs:
process:..." line here.

> 'add the kernel.org UID to your key'. Added SPDX-License-Identifier
> to fix checkpatch.pl warning. Tested kernel using qemu-system-aarch64

You don't need to mention how you tested it (great that you did, but it
doesn't need to be in the commit).

> with busybox inside a multipass ubuntu VM on macos.

I suggest that your submission should look like this:

    Subject: docs: process: maintainer-pgp-guide: update kernel.org docs link

    Update http link to the documentation about how to add a kernel.org UID to
    the maintainer's key. Add missing SPDX-License-Identifier to fix a
    checkpatch warning.

    Signed-off-by: ...

This has the following improvements:

- removes duplicate info that is already in the subject
- uses imperative mood that is required for commits (update vs updated)
  see: https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

> Signed-off-by: Amitabh Srivastava <amitabh@amidevlab.com>
> Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

You shouldn't do this -- I didn't actually reply with  a "Reviewed-by"
trailer. These trailers are given by the reviewer to indicate "I have reviewed
this and didn't find any problems with the patch. You should only add trailers
that you have actually received from reviewers.

Please send a v3 with these fixes and that should earn you a "Reviewed-by."

Best regards,
-- 
KR

      reply	other threads:[~2026-02-03 14:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  4:59 Amitabh Srivastava
2026-02-03 14:48 ` Konstantin Ryabitsev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203-spicy-terrestrial-jaguarundi-701efd@lemur \
    --to=konstantin@linuxfoundation.org \
    --cc=amitabh@amidevlab.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox