workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
	Kees Cook <kees@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Miguel Ojeda <ojeda@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	SeongJae Park <sj@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Simon Glass <simon.glass@canonical.com>,
	Lee Jones <lee@kernel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	NeilBrown <neilb@ownmail.net>, Theodore Ts'o <tytso@mit.edu>,
	Sasha Levin <sashal@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Vlastimil Babka <vbabka@suse.cz>,
	workflows@vger.kernel.org, ksummit@lists.linux.dev
Subject: Re: [PATCH] [v6] Documentation: Provide guidelines for tool-generated content
Date: Fri, 23 Jan 2026 10:30:40 -0500	[thread overview]
Message-ID: <20260123103040.7752d6c1@gandalf.local.home> (raw)
In-Reply-To: <20260119200418.89541-1-dave.hansen@linux.intel.com>

On Mon, 19 Jan 2026 12:04:18 -0800
Dave Hansen <dave.hansen@linux.intel.com> wrote:

I decided to go over it one last time.
> +
> +Out of Scope
> +============
> +
> +These guidelines do not apply to tools that make trivial tweaks to
> +preexisting content. Nor do they pertain to tooling that helps with
> +menial tasks. Some examples:
> +
> + - Spelling and grammar fix ups, like rephrasing to imperative voice
> + - Typing aids like identifier completion, common boilerplate or
> +   trivial pattern completion
> + - Purely mechanical transformations like variable renaming
> + - Reformatting, like running Lindent, ``clang-format`` or
> +   ``rust-fmt``
> +
> +Even whenever your tool use is out of scope, you should still always

Somehow the above reads really weird to me. "Even whenever your tool use is
out of scope". Do you mean "Even when your tool use is out of scope" ?


> +consider if it would help reviewing your contribution if the reviewer
> +knows about the tool that you used.
> +

Other than that, LGTM!

Thanks,

-- Steve

      parent reply	other threads:[~2026-01-23 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 20:04 Dave Hansen
2026-01-20 21:56 ` Jonathan Corbet
2026-01-23 15:30 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260123103040.7752d6c1@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kees@kernel.org \
    --cc=ksummit@lists.linux.dev \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mcgrof@kernel.org \
    --cc=neilb@ownmail.net \
    --cc=ojeda@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=sashal@kernel.org \
    --cc=shuah@kernel.org \
    --cc=simon.glass@canonical.com \
    --cc=sj@kernel.org \
    --cc=tytso@mit.edu \
    --cc=vbabka@suse.cz \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox