* [PATCH] docs: checkpatch: Align block comment style
@ 2025-10-17 18:02 Brian Norris
2025-10-17 19:39 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2025-10-17 18:02 UTC (permalink / raw)
To: Dwaipayan Ray, Lukas Bulwahn, Jonathan Corbet
Cc: workflows, linux-kernel, linux-doc, Joe Perches, Brian Norris
Ironically, the block style comments in the checkpatch documentation are
not aligned properly. Correct that.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
Documentation/dev-tools/checkpatch.rst | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst
index d5c47e560324..d7fe023b3080 100644
--- a/Documentation/dev-tools/checkpatch.rst
+++ b/Documentation/dev-tools/checkpatch.rst
@@ -461,16 +461,16 @@ Comments
line comments is::
/*
- * This is the preferred style
- * for multi line comments.
- */
+ * This is the preferred style
+ * for multi line comments.
+ */
The networking comment style is a bit different, with the first line
not empty like the former::
/* This is the preferred comment style
- * for files in net/ and drivers/net/
- */
+ * for files in net/ and drivers/net/
+ */
See: https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting
--
2.51.0.858.gf9c4a03a3a-goog
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] docs: checkpatch: Align block comment style
2025-10-17 18:02 [PATCH] docs: checkpatch: Align block comment style Brian Norris
@ 2025-10-17 19:39 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2025-10-17 19:39 UTC (permalink / raw)
To: Brian Norris, Dwaipayan Ray, Lukas Bulwahn, Jonathan Corbet
Cc: workflows, linux-kernel, linux-doc, Joe Perches
On 10/17/25 11:02 AM, Brian Norris wrote:
> Ironically, the block style comments in the checkpatch documentation are
> not aligned properly. Correct that.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
However, I would just remove the entire second comment block and
its lead-in comment.
Networking no longer has its own comment style and it looks like
checkpatch no longer checks for that.
> ---
>
> Documentation/dev-tools/checkpatch.rst | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst
> index d5c47e560324..d7fe023b3080 100644
> --- a/Documentation/dev-tools/checkpatch.rst
> +++ b/Documentation/dev-tools/checkpatch.rst
> @@ -461,16 +461,16 @@ Comments
> line comments is::
>
> /*
> - * This is the preferred style
> - * for multi line comments.
> - */
> + * This is the preferred style
> + * for multi line comments.
> + */
>
> The networking comment style is a bit different, with the first line
> not empty like the former::
>
> /* This is the preferred comment style
> - * for files in net/ and drivers/net/
> - */
> + * for files in net/ and drivers/net/
> + */
>
> See: https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-17 19:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-17 18:02 [PATCH] docs: checkpatch: Align block comment style Brian Norris
2025-10-17 19:39 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox