From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A927630149A for ; Wed, 24 Sep 2025 11:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758714756; cv=none; b=AQDtDP1LBFkO0juJnc/Cc8KASrreoDRd/a3E+boADXQ5Xd3Ws4l8UNLHYh464lSrK/T3nYPnubP4UFtl85W6suOKLqfnV2pM0O1uZWqZT5l/BRwMVyDAImPqzoy/GrgHCSJLXL4SwQXSfXOTNj6ixvsbzALDKOZsAwkbW9Lmja4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758714756; c=relaxed/simple; bh=iAqT9ehP+7na6p9OmCJ4sZ82YPBCnKZ9ZITAqnPBA1U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H/JcmfW2VktcjFQjOD1glpQDCA6941oKSHiWRUYPkpa0wwQ1XXnar5G/tYv2F/QxrK0bYq6ixkuIq4fcGGqQT5tToZMH5gWawXFMekiUWQosSyWG0TMezA0f0rghs4JiDxVr8M9MFM40vY9+kQmGXcVbGzFIYvoUDwZrtnq5+4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MHTYa/k+; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MHTYa/k+" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-330b4739538so4690007a91.3 for ; Wed, 24 Sep 2025 04:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758714750; x=1759319550; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CDvSRov2FamkqE0fpRbb1mATCdcadu0+ybcKu6XxB6c=; b=MHTYa/k+6ECs357AhrvtLv3+d+73xCHlewJANdPDeVVBs4baqSQks4VcCRT3od2KlD TGstrAuMWBc3jmmoZFx+oae35ZAvAYvywhAtWk2ZbtXMVzz47auOqwqvix62PsKZ5HDB 36hB/dC9CSViXW+tHKbePe2QIXG4dOi9JiVZHJz9MWiaHSfgRFPGEcCDVSXoiXS71Byt r6tXUrrdi1JcuS+HfNnQjpWww13adXmfdXFef4q0uSE58I3Y/7SFYC6nzS6TZRqHcj3M kN3ZI6v9QgwY2aUnn4LLb4CoIyCcZIaiHzajCEybkKvMhUz+XWRcCQoiYetvmzfu6JcM 4uzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758714750; x=1759319550; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CDvSRov2FamkqE0fpRbb1mATCdcadu0+ybcKu6XxB6c=; b=GCUXgbEHf9BvGy9CFHZd1TSfvYDZL3kcDptvCA9yPgGvXHSIM9251Rg1Ipu2dbURIm c1+HHrrIR4tciQCr1yw8SVabftPoif9bJ66VPYCL8zFkeAjBpTrBSSRWN6q40IrP35En 2x/xWAuRDkFATFWy5oghwxtoZO0WTnFV2dc80Xs6ksq0E8kExRtPNrauUePv9Z5L35Hn 7uOfG9TgqC6N5MdIzNtO1KVG6Ttl85+knP4cmD+0+HsGdlcUBAlWGS393wgVMy+KEO4X chnpDJI2sBhDN/tEMZnIpqFgHicQ125A2pbv28NjaMb0hE9kPbJPay28yVNDObMCzReZ Qffw== X-Forwarded-Encrypted: i=1; AJvYcCUSOY7VUu6wih6DuoBHO/LmPRt+LaqpXsyB4wHunsJtUH5f84jEiiQRTAcjSUdXGeR6snJjjg17FNU=@vger.kernel.org X-Gm-Message-State: AOJu0YzzGo9kqouDx+iDN8rfpCt5bGXThC58UFCdlJi7PqM/o+ojG+15 e2ag3Tj/4nPj4pPNKnZG+uGLdcCraXkn5zavBdDCepVy1HB0qaKFCOS3 X-Gm-Gg: ASbGncsq4TKSWQDe9SpgL9rvzHQXl7mCqie9LqKNy3j1ES0Dq4HJh+oxMSTVbmy7Jde bNqXSG2A3Rb82g8uD1Vke02end8+ypbUNTDofxwNSZfpggdONvXmax9EHskUyA6uXyFdlrDDW93 dOdzVJQceYG+XBSeY9oStni3aH6QUzWGXXEAkIMgqkhHl6cisIdXWrPAcWrCFl0rafzPcYU5EVv sqSFwgu4YRg/aQwlZmAqBLZjg/p0yfuzgKGpyOaJa6GUUVWLwhMxE0hbkahxpY2+ZQ0R9WmKvCy 2KoqZhYyuw1Fd4wrTgxIh9Kt466kPDZanzZOZw/iyBQhCj0SM4Hg47axN/ftm4LyTu1+IQylPvT PmPpTxK20a61w46Qsys3mD3pubA== X-Google-Smtp-Source: AGHT+IF5ZwoBk0ceUXLZjQvXdKYyDk7CfR+Or0oVbNtL2fgYtH3GTtcS1SuTeoBLjpovsRj6PgtdCw== X-Received: by 2002:a17:90b:1844:b0:32e:87fa:d95f with SMTP id 98e67ed59e1d1-332a98f6f1fmr6851528a91.32.1758714749765; Wed, 24 Sep 2025 04:52:29 -0700 (PDT) Received: from localhost ([23.142.224.65]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3341bd90587sm2190418a91.6.2025.09.24.04.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 04:52:29 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v5 15/23] mm/ksw: manage probe and HWBP lifecycle via procfs Date: Wed, 24 Sep 2025 19:50:58 +0800 Message-ID: <20250924115124.194940-16-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250924115124.194940-1-wangjinchao600@gmail.com> References: <20250924115124.194940-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Allow dynamic enabling/disabling of KStackWatch through user input of proc. With this patch, the entire system becomes functional. Signed-off-by: Jinchao Wang --- mm/kstackwatch/kernel.c | 55 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/mm/kstackwatch/kernel.c b/mm/kstackwatch/kernel.c index 4a06ddadd9c7..11aa06908ff1 100644 --- a/mm/kstackwatch/kernel.c +++ b/mm/kstackwatch/kernel.c @@ -13,6 +13,43 @@ static struct ksw_config *ksw_config; static atomic_t config_file_busy = ATOMIC_INIT(0); +static bool watching_active; + +static int ksw_start_watching(void) +{ + int ret; + + /* + * Watch init will preallocate the HWBP, + * so it must happen before stack init + */ + ret = ksw_watch_init(); + if (ret) { + pr_err("ksw_watch_init ret: %d\n", ret); + return ret; + } + + ret = ksw_stack_init(); + if (ret) { + pr_err("ksw_stack_init ret: %d\n", ret); + ksw_watch_exit(); + return ret; + } + watching_active = true; + + pr_info("start watching: %s\n", ksw_config->user_input); + return 0; +} + +static void ksw_stop_watching(void) +{ + ksw_stack_exit(); + ksw_watch_exit(); + watching_active = false; + + pr_info("stop watching: %s\n", ksw_config->user_input); +} + struct param_map { const char *name; /* long name */ const char *short_name; /* short name (2 letters) */ @@ -126,6 +163,9 @@ static ssize_t kstackwatch_proc_write(struct file *file, if (copy_from_user(input, buffer, count)) return -EFAULT; + if (watching_active) + ksw_stop_watching(); + input[count] = '\0'; strim(input); @@ -140,12 +180,22 @@ static ssize_t kstackwatch_proc_write(struct file *file, return ret; } + ret = ksw_start_watching(); + if (ret) { + pr_err("Failed to start watching with %d\n", ret); + return ret; + } + return count; } static int kstackwatch_proc_show(struct seq_file *m, void *v) { - seq_printf(m, "%s\n", ksw_config->user_input); + if (watching_active) + seq_printf(m, "%s\n", ksw_config->user_input); + else + seq_puts(m, "not watching\n"); + return 0; } @@ -193,6 +243,9 @@ static int __init kstackwatch_init(void) static void __exit kstackwatch_exit(void) { + if (watching_active) + ksw_stop_watching(); + remove_proc_entry("kstackwatch", NULL); kfree(ksw_config->func_name); kfree(ksw_config->user_input); -- 2.43.0