workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Greg KH <greg@kroah.com>,
	corbet@lwn.net, linux-doc@vger.kernel.org,
	workflows@vger.kernel.org, josh@joshtriplett.org,
	kees@kernel.org, konstantin@linuxfoundation.org,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: Re: [PATCH 0/4] Add agent coding assistant configuration to Linux kernel
Date: Wed, 30 Jul 2025 13:05:31 -0400	[thread overview]
Message-ID: <20250730130531.4855a38b@gandalf.local.home> (raw)
In-Reply-To: <aIpKCXrc-k2Dx43x@lappy>

On Wed, 30 Jul 2025 12:36:25 -0400
Sasha Levin <sashal@kernel.org> wrote:

> >
> >That sounds pretty much exactly as what I was stating in our meeting. That
> >is, it is OK to submit a patch written with AI but you must disclose it. It
> >is also the right of the Maintainer to refuse to take any patch that was
> >written in AI. They may feel that they want someone who fully understands  
> 
> This should probably be a stronger statement if we don't have it in the
> docs yet: a maintainer can refuse to take any patch, period.

I disagree with that. They had better have technical reasons to refuse to
take a patch. I would have big qualms if a maintainer just said "I don't
like you and I'm not going to take any patches from you".

This is a community project, and maintainers have been overridden before.
Luckily, Linus has been pretty good at getting changes into the kernel when
there was no clear technical argument that they should not be accepted.

I believe the policy is that a maintainer may refuse any patch based on
technical reasons. Now, patches can and are delayed due to maintainers just
not having the time to review the patch. But that is eventually resolved if
enough resources come into play.

My point here is that AI can now add questions that maintainers can't
answer. Is it really legal? Can the maintainer trust it? Yes, these too can
fall under the "technical reasons" but having a clear policy that states
that a maintainer may not want to even bother with AI generated code can
perhaps give the maintainer something to point to if push comes to shove.

> 
> >what that patch does, and AI can cloud the knowledge of that patch from the
> >author.  
> 
> Maybe we should unify this with the academic research doc we already
> have?

I wouldn't think so. This is about submitting patches and a statement there
may be easier found by those about to submit an AI patch. Just because they
are using AI doesn't mean they'll think it's an academic research.

> 
> This way we can extend MAINTAINERS to indicate which subsystems are
> more open to research work (drivers/staging/ comes to mind) vs ones that
> aren't.

I wouldn't call it research work. Right now people who may be playing with
AI models may think it's "research", but that's not going to be the
majority of AI submissions.

> 
> Some sort of a "traffic light" system:
> 
>   1. Green: the subsystem is happy to receive patches from any source.
> 
>   2. Yellow: "If you're unfamiliar with the subsystem and using any
>   tooling to generate your patches, please have a reviewed-by from a
>   trusted developer before sending your patch".
> 
>   3. No tool-generated patches without prior maintainer approval.

Perhaps. Of course there's the Coccinelle scripts that fix a bunch of code
around the kernel that will like be ignored in this. But this may still be
a good start.

-- Steve

  parent reply	other threads:[~2025-07-30 17:05 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27 19:57 Sasha Levin
2025-07-27 19:57 ` [PATCH 1/4] agents: add unified agent coding assistant configuration Sasha Levin
2025-07-28  2:37   ` Kees Cook
2025-07-28  4:43     ` Sasha Levin
2025-07-28  5:16       ` Kees Cook
2025-07-28  5:39         ` Sasha Levin
2025-07-30 22:06   ` Kevin Hilman
2025-07-30 23:47     ` Sasha Levin
2025-08-01 20:53     ` Rob Herring
2025-08-08 18:07       ` Kevin Hilman
2025-07-27 19:58 ` [PATCH 2/4] agents: add core development references Sasha Levin
2025-07-28  2:39   ` Kees Cook
2025-07-28  5:00     ` Sasha Levin
2025-07-28  5:10       ` Kees Cook
2025-07-28  5:59         ` Sasha Levin
2025-07-28  6:18           ` Kees Cook
2025-07-28 12:35             ` Sasha Levin
2025-07-30 16:25             ` Sasha Levin
2025-07-30 17:35               ` Al Viro
2025-07-30 18:29                 ` Sasha Levin
2025-07-30 18:18               ` Matthew Wilcox
2025-07-30 18:41                 ` Sasha Levin
2025-07-28  4:24   ` Greg KH
2025-07-28  4:52     ` Sasha Levin
2025-07-28  5:02       ` Kees Cook
2025-07-27 19:58 ` [PATCH 3/4] agents: add coding style documentation and rules Sasha Levin
2025-07-28  2:40   ` Kees Cook
2025-07-28  5:10     ` Sasha Levin
2025-07-28  5:21       ` Kees Cook
2025-07-28  6:03         ` Sasha Levin
2025-07-30  9:31           ` Krzysztof Kozlowski
2025-07-30 14:48             ` Jakub Kicinski
2025-07-30 15:10             ` Steven Rostedt
2025-07-27 19:58 ` [PATCH 4/4] agents: add legal requirements and agent attribution guidelines Sasha Levin
2025-07-28  2:43   ` Kees Cook
2025-08-05 22:08   ` Jeff Johnson
2025-08-05 23:11     ` Laurent Pinchart
2025-08-05 23:33       ` Sasha Levin
2025-08-06 14:12   ` Konstantin Ryabitsev
2025-08-06 21:53     ` Sasha Levin
2025-07-28  7:58 ` [PATCH 0/4] Add agent coding assistant configuration to Linux kernel Vlastimil Babka
2025-07-28  9:27   ` David Hildenbrand
2025-07-28 10:37     ` Greg KH
2025-07-28 10:47       ` David Hildenbrand
2025-07-28 13:05         ` Sasha Levin
2025-08-04  9:23           ` Michal Hocko
2025-08-04  9:41             ` Michal Hocko
2025-08-04 13:25             ` Sasha Levin
2025-08-04 22:03               ` Jiri Kosina
2025-08-04 22:14                 ` Steven Rostedt
2025-08-04 22:30                   ` Jiri Kosina
2025-08-04 22:53                   ` dan.j.williams
2025-08-04 23:30                     ` Sasha Levin
2025-08-04 23:39                       ` Laurent Pinchart
2025-08-05 13:29                         ` Steven Rostedt
2025-07-28 11:57   ` Sasha Levin
2025-07-28  8:42 ` Lorenzo Stoakes
2025-07-28 10:35   ` Greg KH
2025-07-28 10:52     ` Lorenzo Stoakes
2025-07-28 12:45       ` Sasha Levin
2025-07-28 13:13         ` Lorenzo Stoakes
2025-07-28 13:23           ` Sasha Levin
2025-07-28 13:28             ` Lorenzo Stoakes
2025-07-30 15:27       ` Steven Rostedt
2025-07-30 15:34         ` Lorenzo Stoakes
2025-07-30 16:18           ` Steven Rostedt
2025-07-30 16:33             ` Mauro Carvalho Chehab
2025-07-30 16:36             ` Sasha Levin
2025-07-30 16:59               ` Lorenzo Stoakes
2025-07-30 17:12                 ` Sasha Levin
2025-07-30 17:23                   ` Lorenzo Stoakes
2025-07-30 17:32                     ` Steven Rostedt
2025-07-30 18:03                       ` Sasha Levin
2025-07-30 18:18                         ` Lorenzo Stoakes
2025-07-30 18:04                       ` Lorenzo Stoakes
2025-07-30 19:16                         ` Mark Brown
2025-07-30 17:25                   ` Steven Rostedt
2025-07-30 17:34                 ` Mark Brown
2025-07-30 17:36                 ` Kees Cook
2025-08-04 10:20                 ` Jiri Kosina
2025-07-30 17:05               ` Steven Rostedt [this message]
2025-07-30 17:46                 ` Sasha Levin
2025-07-30 17:59                   ` Al Viro
2025-07-30 18:10                     ` Sasha Levin
2025-07-30 18:24                       ` Lorenzo Stoakes
2025-07-30 18:59                         ` Sasha Levin
2025-07-30 19:10                     ` Theodore Ts'o
2025-07-30 19:40                       ` Steven Rostedt
2025-07-30 19:51                       ` Al Viro
2025-07-30 19:27                   ` Steven Rostedt
2025-07-31  0:02                   ` Mauro Carvalho Chehab
2025-07-30 16:40             ` Dr. David Alan Gilbert
2025-07-30 17:10               ` Lorenzo Stoakes
2025-07-30 17:20                 ` Steven Rostedt
2025-07-30 17:33                   ` Lorenzo Stoakes
2025-07-30 17:12               ` Steven Rostedt
2025-07-30 17:39                 ` Dr. David Alan Gilbert
2025-07-30 17:51               ` Kees Cook
2025-07-30 16:58             ` Lorenzo Stoakes
2025-07-28 10:56     ` Laurent Pinchart
2025-08-12 18:13 ` Nicolas Frattaroli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250730130531.4855a38b@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=corbet@lwn.net \
    --cc=greg@kroah.com \
    --cc=josh@joshtriplett.org \
    --cc=kees@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=sashal@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox