From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ACCD236A70; Thu, 3 Jul 2025 16:00:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751558405; cv=none; b=DsnpmzbX/wSam+8MgUlwxlReGaRnqTLbkYu0N6HMDVCK+hyJlFs4BdHHSRUgfcct6ZMB+trxLxS2s1jmhmmg2V7oHA1k9enBlhUY+Htbx25ut3hT0yH/Xo54qKMolBxz1RjVOXnMsVJOiQ85zwn3ADZ6jxdyQqCMYjEGmz9T9CE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751558405; c=relaxed/simple; bh=3Pj0427xdMZ4I26tk/jkLsUjXBeSTMEAHLv8oOJqYuA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qKgl8vlhfxghCelZTp2jNnLrsYpqsT0Z4ZcIIPpyKccstlGVp1D/uDZMmAovHbrCfUVs2P5z4bS4Lxm+heq/My2VcHQXaty16gs8ZJxNx/80rnO5Ao9QfdbKbHVc7Th8D2dYoBO1zYo+4o8z1wodmVOalTXqupGjzVND6p/yyik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=gNolMbEw; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=+PJjqBcy; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="gNolMbEw"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="+PJjqBcy" Date: Thu, 3 Jul 2025 17:59:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1751558401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zfHdGhts9p3gqu5lIIaqmscwxy1s8kWHcDGpikLQ3tA=; b=gNolMbEwCOCl4yMfeC/iBYFgUXptyQPBLssa09PXqJz2RbbIcf/S6akhWNaqPgdhm1V6Ul DX4ollftygERDLdRi0iunHcisvZi0sfLuc8mZoQ75Yx/SSqog2VTR7gMfkAQmhjtmS5JUH uTjp3iOMwnk8f/y3S8jz9M85OEF7yMKJQOQuEKJmyFcuRcRsaQ/n5/buUuYnLW5kGUqwbO /scb/zQT6O/4Ty8dIb98gWkUFqiKKKLNu9qLkufDN1Wg2LqLb8NuDkso2aOLFDzHpWQS0h 3qoyvFzruOC4bKi4VIy++09MULhWe3GlnAzKoTbqRlAeO/oyVuZExImtGIUCPw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1751558401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zfHdGhts9p3gqu5lIIaqmscwxy1s8kWHcDGpikLQ3tA=; b=+PJjqBcyqg/NfQCEreDNyHdRcqK4bgObWbiIPBry2m5lO9Y6u/e7h1bFDLZGgHc3b//iej BKTJKyZ7ULEMq+Dw== From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Rae Moar Cc: Masahiro Yamada , Nathan Chancellor , Andrew Morton , Willy Tarreau , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Brendan Higgins , David Gow , Shuah Khan , Jonathan Corbet , Nicolas Schier , Christophe Leroy , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, workflows@vger.kernel.org Subject: Re: [PATCH v4 09/15] kunit: tool: Parse skipped tests from kselftest.h Message-ID: <20250703175819-09e1d46a-ab23-40bf-a7cb-de191d81b154@linutronix.de> References: <20250626-kunit-kselftests-v4-0-48760534fef5@linutronix.de> <20250626-kunit-kselftests-v4-9-48760534fef5@linutronix.de> Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jul 01, 2025 at 05:22:07PM -0400, Rae Moar wrote: > On Thu, Jun 26, 2025 at 2:10 AM Thomas Weißschuh > wrote: > > -TEST_RESULT = re.compile(r'^\s*(ok|not ok) ([0-9]+) (- )?([^#]*)( # .*)?$') > > +TEST_RESULT = re.compile(r'^\s*(ok|not ok) ([0-9]+)? ?(- )?([^#]*)( # .*)?$') > > > > -TEST_RESULT_SKIP = re.compile(r'^\s*(ok|not ok) ([0-9]+) (- )?(.*) # SKIP(.*)$') > > +TEST_RESULT_SKIP = re.compile(r'^\s*(ok|not ok) ([0-9]+)? ?(- )?(.*) # SKIP ?(.*)$') > > My concern with this patch is that this makes the test number optional > ([0-9]+) -> ([0-9]+)? for both the test result regex matches. But if I > do pass in KTAP containing a line where the test number is missing, it > causes the parser to crash because other lines of the code rely on the > match with the test number. > > I would prefer if we keep the test number as required. This is > integral to the KTAP specification and seems to be largely shared by > different frameworks test output. This part of the patch was actually unnecessary, so I dropped it. Good catch, thanks.