From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A6C727FD49 for ; Wed, 11 Jun 2025 13:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749650006; cv=none; b=f6r2N3GUZBPqo/HBzjgYECDbGnUn0gchTmuHdDj6mCHuTSXPI2vHs0IKpQOpe+6M1hbQrk0vQwJZrl31xuFkfuZiHkDgv0bZGYmPfeOP0C2TbgtxnJSaCtJjiS4TWwt8x0zR9DGDTeyxxLnwTwTaicIHbfihVXkl7BNW80a+ilk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749650006; c=relaxed/simple; bh=9SIdAh840g6tydo2JznT4GeDVA5YXlZf24fa0jmn9oM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RKmlIbJnpmVo1xJ978+Mlil6fPN+sZMftpyKJCMcATu+8/W8eTBXnJ+sxx4oX5o+/a2/fFfSh8GIWZHAqBbNN8Yx1KntTYYKxYHcZSVWECwoj1pfTyRYYR87cRzisi68aNR3BR+yrVc4owaf1XG4vXyxJfFS1woWX6Ox5PU4Rnw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WYdAW6iz; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WYdAW6iz" Date: Wed, 11 Jun 2025 15:52:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749649990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4zq30Zx1gm5+DnliSP1IJP9mnbwAcrHCYpwo6PmyzBc=; b=WYdAW6izimj/1gDUnPW+moaf3Nr5+ezwcwuLHSc4IvraMglv8YBB9VUujsatvLjE7apE7p u9v5WzRBHxvmN01qtvUkfX2q9urcqWHuzQ2J9T3qKK3D1YvTQTqQ18DDnJz95VqMnpFJVF LrIlkoskO2W4MhCJ1lY8fuv0ZUIvBeA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Nicolas Schier To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= Cc: Masahiro Yamada , Nathan Chancellor , Andrew Morton , Willy Tarreau , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Brendan Higgins , David Gow , Rae Moar , Shuah Khan , Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Christophe Leroy , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, workflows@vger.kernel.org Subject: Re: [PATCH v3 01/16] kbuild: userprogs: avoid duplicating of flags inherited from kernel Message-ID: <20250611-overjoyed-vengeful-goshawk-0aaf8c@l-nschier-aarch64> References: <20250611-kunit-kselftests-v3-0-55e3d148cbc6@linutronix.de> <20250611-kunit-kselftests-v3-1-55e3d148cbc6@linutronix.de> Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250611-kunit-kselftests-v3-1-55e3d148cbc6@linutronix.de> Organization: AVM GmbH X-Migadu-Flow: FLOW_OUT On Wed, Jun 11, 2025 at 09:38:07AM +0200, Thomas Weißschuh wrote: > The duplication makes maintenance harder. Changes need to be done in two > places and the lines will grow overly long. > > Use an intermediary variable instead. > > Signed-off-by: Thomas Weißschuh > --- > Makefile | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Reviewed-by: Nicolas Schier