From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: brendan.higgins@linux.dev, davidgow@google.com, rmoar@google.com,
corbet@lwn.net, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, workflows@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kunit: add tips to clean source tree to build help message
Date: Wed, 30 Apr 2025 07:18:25 +0200 [thread overview]
Message-ID: <20250430071825.1e196cb1@foz.lan> (raw)
In-Reply-To: <dc8f4035a8d493be9ddc0e868a3ffd67626cca00.1745965121.git.skhan@linuxfoundation.org>
Em Tue, 29 Apr 2025 16:27:12 -0600
Shuah Khan <skhan@linuxfoundation.org> escreveu:
> Add tips to clean source tree to build help message. When user run
> kunit.py after building another kernel for ARCH=foo, it is necessary
> to run 'make ARCH=foo mrproper' to remove all build artifacts generated
> during the build. In such cases, kunit build could fail.
>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
> tools/testing/kunit/kunit.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py
> index 7f9ae55fd6d5..db86a396ed33 100755
> --- a/tools/testing/kunit/kunit.py
> +++ b/tools/testing/kunit/kunit.py
> @@ -583,7 +583,7 @@ def main(argv: Sequence[str]) -> None:
> 'the options in .kunitconfig')
> add_common_opts(config_parser)
>
> - build_parser = subparser.add_parser('build', help='Builds a kernel with KUnit tests')
> + build_parser = subparser.add_parser('build', help='Builds a kernel with KUnit tests. Successful build depends on a clean source tree. Run mrproper to clean generated artifcats for prior ARCH=foo kernel build. Run 'make ARCH=foo mrproper')
> add_common_opts(build_parser)
> add_build_opts(build_parser)
>
Would be better instead to detect if the last build was not done
by kunit.py and call "make mrproper" inside kunit.py?
Thanks,
Mauro
next prev parent reply other threads:[~2025-04-30 5:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 22:27 [PATCH 0/2] Update kunit doc and tool with tips to build errors Shuah Khan
2025-04-29 22:27 ` [PATCH 1/2] doc: kunit: add information about cleaning source trees Shuah Khan
2025-04-29 22:29 ` Randy Dunlap
2025-04-29 23:33 ` Shuah Khan
2025-04-29 22:27 ` [PATCH 2/2] kunit: add tips to clean source tree to build help message Shuah Khan
2025-04-29 22:49 ` Jonathan Corbet
2025-04-29 23:34 ` Shuah Khan
2025-04-30 3:54 ` David Gow
2025-04-30 21:25 ` Shuah Khan
2025-05-01 0:40 ` Shuah Khan
2025-04-30 5:18 ` Mauro Carvalho Chehab [this message]
2025-04-30 21:28 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250430071825.1e196cb1@foz.lan \
--to=mchehab+huawei@kernel.org \
--cc=brendan.higgins@linux.dev \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rmoar@google.com \
--cc=skhan@linuxfoundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox