From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Brendan Jackman <jackmanb@google.com>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, workflows@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2] checkpatch: Add support for Checkpatch-ignore patch footer
Date: Tue, 14 Jan 2025 14:26:44 -0500 [thread overview]
Message-ID: <20250114-olivine-adder-of-weather-1eaabf@meerkat> (raw)
In-Reply-To: <CA+i-1C2OrLDvp_xiomc_B96vZu8G8KRrg7KBHATz2y7KMO8UsA@mail.gmail.com>
On Tue, Jan 14, 2025 at 07:29:14PM +0100, Brendan Jackman wrote:
> > Tweaks aimed at checkpatch are only useful during the code review stage, so
> > once that code is accepted upstream, they become wholly irrelevant. A
> > checkpatch trailer in the permanent commit record serves no purpose, not even
> > a historical one.
>
> Yeah that's a good argument for them being unnecessary. It's not clear
> why them persisting beyond their useful lifetime would be a problem
> though. Any given reader of a commit message is already very likely to
> see tags they don't care about in that moment, is that something
> people really complain about?
Yes, I expect Linus will reject commits that carry that trailer on the exact
grounds that I brought up. He stated multiple times that a commit message
should only carry trailers that explain the context and the reason for that
change.
-K
next prev parent reply other threads:[~2025-01-14 19:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 16:04 [PATCH 0/2] " Brendan Jackman
2025-01-13 16:04 ` [PATCH 1/2] " Brendan Jackman
2025-01-13 19:15 ` Joe Perches
2025-01-14 11:42 ` Brendan Jackman
2025-01-14 11:43 ` Brendan Jackman
2025-01-14 13:34 ` Konstantin Ryabitsev
2025-01-14 14:25 ` Brendan Jackman
2025-01-14 16:04 ` Konstantin Ryabitsev
2025-01-14 18:29 ` Brendan Jackman
2025-01-14 19:26 ` Konstantin Ryabitsev [this message]
2025-01-15 9:58 ` Brendan Jackman
2025-01-13 16:04 ` [PATCH 2/2] docs: checkpatch: Document " Brendan Jackman
2025-01-13 16:20 ` [PATCH 0/2] checkpatch: Add support for " Matthew Wilcox
2025-01-13 17:11 ` Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114-olivine-adder-of-weather-1eaabf@meerkat \
--to=konstantin@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=jackmanb@google.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox