From: Vlastimil Babka <vbabka@suse.cz>
To: Joe Perches <joe@perches.com>
Cc: workflows@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Thorsten Leemhuis <linux@leemhuis.info>,
Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org, Vlastimil Babka <vbabka@suse.cz>
Subject: [PATCH 1/2] get_maintainer: decouple subsystem status from maintainer role
Date: Tue, 14 Jan 2025 09:57:54 +0100 [thread overview]
Message-ID: <20250114-b4-get_maintainer-v1-1-ecf40f0d032d@suse.cz> (raw)
In-Reply-To: <20250114-b4-get_maintainer-v1-0-ecf40f0d032d@suse.cz>
The script currently uses the subystem's status (S: field in
MAINTAINERS) to change how maintainers are reported. One prominent
example is when the status is Supported, the maintainers are reported as
"(supporter:SUBSYSTEM)".
This is misleading, as the Supported status defined as "Someone is
actually paid to look after this." may not in fact apply to everyone
listed as a maintainer, but only to a subset.
It has also been confusing people about what "supporter" means and has
required updates to the documentation [1].
Thus stop applying the subsystem status to change "maintainer:" to
anything else, as maintainers are maintainers. Instead, if the subsystem
status is not the most common one (Maintained), indicate it as part of
the subsystem name. So for example, instead of "(supporter:SUBSYSTEM)"
report "(maintainer:SUBSYSTEM [supported])".
The only exception not changed here is the status "Buried alive in
reporters" used only in "THE REST" section and reported as "chief
penguin" because the script uses the same terminology also for the
corresponding (non-default) command line option.
[1] https://lore.kernel.org/all/20221006162413.858527-1-bryan.odonoghue@linaro.org/
Reviewed-by: Kees Cook <kees@kernel.org>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
---
scripts/get_maintainer.pl | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 5ac02e19873722d0f5bf3ac8de8374338c7bddc3..82a0032f4d4c7dad876afeb601b5f1957d1a838f 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1286,6 +1286,7 @@ sub get_maintainer_role {
my $role = "unknown";
my $subsystem = get_subsystem_name($index);
+ my $substatus = "";
for ($i = $start + 1; $i < $end; $i++) {
my $tv = $typevalue[$i];
@@ -1299,21 +1300,15 @@ sub get_maintainer_role {
}
$role = lc($role);
- if ($role eq "supported") {
- $role = "supporter";
- } elsif ($role eq "maintained") {
+ if ($role eq "maintained") {
$role = "maintainer";
- } elsif ($role eq "odd fixes") {
- $role = "odd fixer";
- } elsif ($role eq "orphan") {
- $role = "orphan minder";
- } elsif ($role eq "obsolete") {
- $role = "obsolete minder";
} elsif ($role eq "buried alive in reporters") {
$role = "chief penguin";
+ } else {
+ $substatus = " [" . $role . "]";
+ $role = "maintainer";
}
-
- return $role . ":" . $subsystem;
+ return $role . ":" . $subsystem . $substatus;
}
sub get_list_role {
--
2.47.1
next prev parent reply other threads:[~2025-01-14 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 8:57 [PATCH 0/2] get_maintainer: report subsystem status separately " Vlastimil Babka
2025-01-14 8:57 ` Vlastimil Babka [this message]
2025-01-14 8:57 ` [PATCH 2/2] get_maintainer: print subsystem status also for reviewers and lists Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114-b4-get_maintainer-v1-1-ecf40f0d032d@suse.cz \
--to=vbabka@suse.cz \
--cc=bryan.odonoghue@linaro.org \
--cc=joe@perches.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=tytso@mit.edu \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox