From: "Theodore Ts'o" <tytso@mit.edu>
To: Neal Gompa <neal@gompa.dev>
Cc: Miguel Ojeda <ojeda@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Sami Tolvanen <samitolvanen@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
tech-board@groups.linuxfoundation.org,
Steven Rostedt <rostedt@goodmis.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 3/3] docs: submitting-patches: clarify that signers may use their discretion on tags
Date: Mon, 13 Jan 2025 09:22:27 -0500 [thread overview]
Message-ID: <20250113142227.GE1514771@mit.edu> (raw)
In-Reply-To: <CAEg-Je-Knta8BtYSbZgX8cZ9Gd-2cpDAUE83dCJZbTbqmSfcKA@mail.gmail.com>
On Sun, Jan 12, 2025 at 10:47:02AM -0500, Neal Gompa wrote:
>
> A tag must not be dropped without the tag submitter's authorization.
> Otherwise it doesn't matter what you write here, the submitter *will*
> feel unwelcome.
>
> It is rude and discouraging to do so without their acceptance of doing so.
In some cases, if the reviewer hasn't taken the less than subtle hints
that their reviews are unwelcome and are discouraging patch
submitters, as far as I'm concerned, if they feel unwelcome, that is a
*feature* and not a *bug*.
I'm not saying that is the case for you, but there are reviewers that
add negative value in the ecosystem. The assumption that all tag
submitters are people that need to feel welcome might mostly true, but
it is not always the case. This is why it MUST ultimately be up to
the maintainer. I do not want the rules that force me to reward
people that should be discouraged, not encouraged.
- Ted
next prev parent reply other threads:[~2025-01-13 14:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 15:29 [PATCH 0/3] Clarifications around Acked-by and "# Suffix" proposal Miguel Ojeda
2025-01-12 15:29 ` [PATCH 1/3] docs: submitting-patches: clarify Acked-by and introduce "# Suffix" Miguel Ojeda
2025-01-12 15:52 ` Neal Gompa
2025-01-12 17:24 ` Greg Kroah-Hartman
2025-01-13 11:52 ` Krzysztof Kozlowski
2025-01-12 15:29 ` [PATCH 2/3] docs: submitting-patches: clarify difference between Acked-by and Reviewed-by Miguel Ojeda
2025-01-12 15:50 ` Neal Gompa
2025-01-12 16:31 ` Miguel Ojeda
2025-01-12 16:35 ` Neal Gompa
2025-01-12 17:10 ` Miguel Ojeda
2025-01-12 19:59 ` Jonathan Corbet
2025-01-12 20:13 ` Neal Gompa
2025-01-13 14:13 ` Theodore Ts'o
2025-01-13 11:48 ` Krzysztof Kozlowski
2025-01-13 12:38 ` Jani Nikula
2025-01-13 15:15 ` Steven Rostedt
2025-01-14 23:13 ` Darrick J. Wong
2025-01-12 17:25 ` Greg Kroah-Hartman
2025-01-13 11:50 ` Krzysztof Kozlowski
2025-01-12 15:29 ` [PATCH 3/3] docs: submitting-patches: clarify that signers may use their discretion on tags Miguel Ojeda
2025-01-12 15:47 ` Neal Gompa
2025-01-12 16:33 ` Miguel Ojeda
2025-01-12 17:24 ` Greg Kroah-Hartman
2025-01-13 13:36 ` Mark Brown
2025-01-13 14:22 ` Theodore Ts'o [this message]
2025-01-13 15:36 ` Steven Rostedt
2025-01-12 17:22 ` Greg Kroah-Hartman
2025-01-13 11:51 ` Krzysztof Kozlowski
2025-01-13 17:47 ` [PATCH 0/3] Clarifications around Acked-by and "# Suffix" proposal Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113142227.GE1514771@mit.edu \
--to=tytso@mit.edu \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=neal@gompa.dev \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=skhan@linuxfoundation.org \
--cc=tech-board@groups.linuxfoundation.org \
--cc=torvalds@linux-foundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox