From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Neal Gompa <neal@gompa.dev>,
Sami Tolvanen <samitolvanen@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
tech-board@groups.linuxfoundation.org,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 3/3] docs: submitting-patches: clarify that signers may use their discretion on tags
Date: Sun, 12 Jan 2025 18:22:29 +0100 [thread overview]
Message-ID: <2025011219-ashen-epilepsy-ba32@gregkh> (raw)
In-Reply-To: <20250112152946.761150-4-ojeda@kernel.org>
On Sun, Jan 12, 2025 at 04:29:46PM +0100, Miguel Ojeda wrote:
> Tags are really appreciated by maintainers in general, since it means
> someone is willing to put their name on a commit, be it as a reviewer,
> tester, etc.
>
> However, signers (i.e. submitters carrying tags from previous versions
> and maintainers applying patches) may need to take or drop tags, on a
> case-by-case basis, for different reasons.
>
> Yet this is not explicitly spelled out in the documentation, thus there
> may be instances [1] where contributors may feel unwelcome.
>
> Thus, to clarify, state this clearly.
>
> Link: https://lore.kernel.org/rust-for-linux/CAEg-Je-h4NitWb2ErFGCOqt0KQfXuyKWLhpnNHCdRzZdxi018Q@mail.gmail.com/ [1]
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
> Documentation/process/submitting-patches.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 7b0ac7370cb1..6754bc15f989 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -614,6 +614,10 @@ process nor the requirement to Cc: stable@vger.kernel.org on all stable
> patch candidates. For more information, please read
> Documentation/process/stable-kernel-rules.rst.
>
> +Finally, while providing tags is welcome and typically very appreciated, please
> +note that signers (i.e. submitters and maintainers) may use their discretion in
> +applying offered tags.
> +
> .. _the_canonical_patch_format:
>
> The canonical patch format
> --
> 2.48.0
>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2025-01-12 17:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 15:29 [PATCH 0/3] Clarifications around Acked-by and "# Suffix" proposal Miguel Ojeda
2025-01-12 15:29 ` [PATCH 1/3] docs: submitting-patches: clarify Acked-by and introduce "# Suffix" Miguel Ojeda
2025-01-12 15:52 ` Neal Gompa
2025-01-12 17:24 ` Greg Kroah-Hartman
2025-01-13 11:52 ` Krzysztof Kozlowski
2025-01-12 15:29 ` [PATCH 2/3] docs: submitting-patches: clarify difference between Acked-by and Reviewed-by Miguel Ojeda
2025-01-12 15:50 ` Neal Gompa
2025-01-12 16:31 ` Miguel Ojeda
2025-01-12 16:35 ` Neal Gompa
2025-01-12 17:10 ` Miguel Ojeda
2025-01-12 19:59 ` Jonathan Corbet
2025-01-12 20:13 ` Neal Gompa
2025-01-13 14:13 ` Theodore Ts'o
2025-01-13 11:48 ` Krzysztof Kozlowski
2025-01-13 12:38 ` Jani Nikula
2025-01-13 15:15 ` Steven Rostedt
2025-01-14 23:13 ` Darrick J. Wong
2025-01-12 17:25 ` Greg Kroah-Hartman
2025-01-13 11:50 ` Krzysztof Kozlowski
2025-01-12 15:29 ` [PATCH 3/3] docs: submitting-patches: clarify that signers may use their discretion on tags Miguel Ojeda
2025-01-12 15:47 ` Neal Gompa
2025-01-12 16:33 ` Miguel Ojeda
2025-01-12 17:24 ` Greg Kroah-Hartman
2025-01-13 13:36 ` Mark Brown
2025-01-13 14:22 ` Theodore Ts'o
2025-01-13 15:36 ` Steven Rostedt
2025-01-12 17:22 ` Greg Kroah-Hartman [this message]
2025-01-13 11:51 ` Krzysztof Kozlowski
2025-01-13 17:47 ` [PATCH 0/3] Clarifications around Acked-by and "# Suffix" proposal Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025011219-ashen-epilepsy-ba32@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=neal@gompa.dev \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=skhan@linuxfoundation.org \
--cc=tech-board@groups.linuxfoundation.org \
--cc=torvalds@linux-foundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox