From: Miguel Ojeda <ojeda@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Miguel Ojeda <ojeda@kernel.org>, Neal Gompa <neal@gompa.dev>,
Sami Tolvanen <samitolvanen@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
tech-board@groups.linuxfoundation.org,
Steven Rostedt <rostedt@goodmis.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Dan Williams <dan.j.williams@intel.com>
Subject: [PATCH 2/3] docs: submitting-patches: clarify difference between Acked-by and Reviewed-by
Date: Sun, 12 Jan 2025 16:29:45 +0100 [thread overview]
Message-ID: <20250112152946.761150-3-ojeda@kernel.org> (raw)
In-Reply-To: <20250112152946.761150-1-ojeda@kernel.org>
Newcomers to the kernel need to learn the different tags that are
used in commit messages and when to apply them. Acked-by is sometimes
misunderstood, since the documentation did not really clarify (up to
the previous commit) when it should be used, especially compared to
Reviewed-by.
The previous commit already clarified who the usual providers of Acked-by
tags are, with examples. Thus provide a clarification paragraph for
the comparison with Reviewed-by, and give a couple examples reusing the
cases given above, in the previous commit.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Acked-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
Documentation/process/submitting-patches.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
index c7a28af235f7..7b0ac7370cb1 100644
--- a/Documentation/process/submitting-patches.rst
+++ b/Documentation/process/submitting-patches.rst
@@ -480,6 +480,12 @@ mergers will sometimes manually convert an acker's "yep, looks good to me"
into an Acked-by: (but note that it is usually better to ask for an
explicit ack).
+Acked-by: is also less formal than Reviewed-by:. For instance, maintainers may
+use it to signify that they are OK with a patch landing, but they may not have
+reviewed it as thoroughly as if a Reviewed-by: was provided. Similarly, a key
+user may not have carried out a technical review of the patch, yet they may be
+satisfied with the general approach, the feature or the user-facing interface.
+
Acked-by: does not necessarily indicate acknowledgement of the entire patch.
For example, if a patch affects multiple subsystems and has an Acked-by: from
one subsystem maintainer then this usually indicates acknowledgement of just
--
2.48.0
next prev parent reply other threads:[~2025-01-12 15:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 15:29 [PATCH 0/3] Clarifications around Acked-by and "# Suffix" proposal Miguel Ojeda
2025-01-12 15:29 ` [PATCH 1/3] docs: submitting-patches: clarify Acked-by and introduce "# Suffix" Miguel Ojeda
2025-01-12 15:52 ` Neal Gompa
2025-01-12 17:24 ` Greg Kroah-Hartman
2025-01-13 11:52 ` Krzysztof Kozlowski
2025-01-12 15:29 ` Miguel Ojeda [this message]
2025-01-12 15:50 ` [PATCH 2/3] docs: submitting-patches: clarify difference between Acked-by and Reviewed-by Neal Gompa
2025-01-12 16:31 ` Miguel Ojeda
2025-01-12 16:35 ` Neal Gompa
2025-01-12 17:10 ` Miguel Ojeda
2025-01-12 19:59 ` Jonathan Corbet
2025-01-12 20:13 ` Neal Gompa
2025-01-13 14:13 ` Theodore Ts'o
2025-01-13 11:48 ` Krzysztof Kozlowski
2025-01-13 12:38 ` Jani Nikula
2025-01-13 15:15 ` Steven Rostedt
2025-01-14 23:13 ` Darrick J. Wong
2025-01-12 17:25 ` Greg Kroah-Hartman
2025-01-13 11:50 ` Krzysztof Kozlowski
2025-01-12 15:29 ` [PATCH 3/3] docs: submitting-patches: clarify that signers may use their discretion on tags Miguel Ojeda
2025-01-12 15:47 ` Neal Gompa
2025-01-12 16:33 ` Miguel Ojeda
2025-01-12 17:24 ` Greg Kroah-Hartman
2025-01-13 13:36 ` Mark Brown
2025-01-13 14:22 ` Theodore Ts'o
2025-01-13 15:36 ` Steven Rostedt
2025-01-12 17:22 ` Greg Kroah-Hartman
2025-01-13 11:51 ` Krzysztof Kozlowski
2025-01-13 17:47 ` [PATCH 0/3] Clarifications around Acked-by and "# Suffix" proposal Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250112152946.761150-3-ojeda@kernel.org \
--to=ojeda@kernel.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=neal@gompa.dev \
--cc=patches@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=skhan@linuxfoundation.org \
--cc=tech-board@groups.linuxfoundation.org \
--cc=torvalds@linux-foundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox