From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Jonathan Corbet <corbet@lwn.net>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>,
Rob Herring <robh@kernel.org>, Frank Li <Frank.li@nxp.com>,
kernel@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH RFC 0/2] docs: process: submitting-patches: clarify imperative mood suggestion
Date: Fri, 20 Dec 2024 10:09:33 +0100 [thread overview]
Message-ID: <20241220-submitting-patches-imperative-v1-0-ee874c1859b3@pengutronix.de> (raw)
Many commit message bodies start off with some background information,
before explaining how they address the situation. This can be arguably
easier to follow than having the imperative in the commit message title
be followed directly by another differently worded or more verbose
imperative in the commit message body and then at the end an
", because ..." with an explanation why things were done this way.
Yet, while the documentation talks about use of imperative mood, it does
not fully explain why, which IMO makes it prone to misunderstanding[1][2].
Therefore adapt the documentation to clarify the intent of the imperative
mood and give an example for how a good commit message can look like.
[1]: https://lore.kernel.org/all/f085aa33-f0b7-49e7-bbfc-d3728d3e3e8c@pengutronix.de/#t
[2]: https://lore.kernel.org/all/Z2RzA5S%2Fch1YDdUD@lizhi-Precision-Tower-5810/
---
Ahmad Fatoum (2):
docs: process: submitting-patches: split canonical patch format section
docs: process: submitting-patches: clarify imperative mood suggestion
Documentation/process/submitting-patches.rst | 74 +++++++++++++++++++---------
1 file changed, 52 insertions(+), 22 deletions(-)
---
base-commit: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
change-id: 20241219-submitting-patches-imperative-248413781db1
Best regards,
--
Ahmad Fatoum <a.fatoum@pengutronix.de>
next reply other threads:[~2024-12-20 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 9:09 Ahmad Fatoum [this message]
2024-12-20 9:09 ` [PATCH RFC 1/2] docs: process: submitting-patches: split canonical patch format section Ahmad Fatoum
2024-12-30 18:38 ` Jonathan Corbet
2024-12-20 9:09 ` [PATCH RFC 2/2] docs: process: submitting-patches: clarify imperative mood suggestion Ahmad Fatoum
2024-12-30 18:40 ` Jonathan Corbet
2025-01-06 14:51 ` Ahmad Fatoum
2025-01-06 14:57 ` Jonathan Corbet
2025-01-06 15:02 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241220-submitting-patches-imperative-v1-0-ee874c1859b3@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=Frank.li@nxp.com \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=kernel@pengutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox