workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Thorsten Leemhuis <linux@leemhuis.info>
Cc: Jonathan Corbet <corbet@lwn.net>,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Simona Vetter <simona.vetter@ffwll.ch>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 DONOTMERGE] docs: clarify rules wrt tagging other people
Date: Mon, 2 Dec 2024 17:17:34 +0100	[thread overview]
Message-ID: <20241202171734.2874a9a3@foz.lan> (raw)
In-Reply-To: <6f1bbdf3-22df-415c-b017-de1cf81af57e@leemhuis.info>

Em Mon, 2 Dec 2024 16:54:49 +0100
Thorsten Leemhuis <linux@leemhuis.info> escreveu:

> On 02.12.24 15:45, Mauro Carvalho Chehab wrote:
> > Em Mon, 2 Dec 2024 14:54:56 +0100
> > Thorsten Leemhuis <linux@leemhuis.info> escreveu:
> >   
> >> On 02.12.24 11:02, Mauro Carvalho Chehab wrote:  
> >>> Em Mon, 2 Dec 2024 09:28:57 +0100
> >>> Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:
> >>>     
> >>>>> +Tagging people requires permission
> >>>>> +----------------------------------
> >>>>> +
> >>>>> +Be careful in the addition of tags to your patches, as all except for Cc:,
> >>>>> +Reported-by:, and Suggested-by: need explicit permission of the person named.
> >>>>> +For the three aforementioned ones implicit permission is sufficient if the
> >>>>> +person contributed to the Linux kernel using that name and email address
> >>>>> +according to the lore archives or the commit history -- and in case of
> >>>>> +Reported-by: and Suggested-by: did the reporting or suggestion in public.
> >>>>> +Note, bugzilla.kernel.org is a public place in this sense, but email addresses
> >>>>> +used there are private; so do not expose them in tags, unless the person used
> >>>>> +them in earlier contributions.    
> >>>
> >>> Hmm... There is another tag that we use without requiring explicit permissions:
> >>>
> >>> 	Requested-by:
> >>>
> >>> There are currently 376 occurrences on 6.13-rc1.
> >>>
> >>> This is used when a maintainer or reviewer publicly requests some changes to
> >>> be added on a patch series.    
> > [...]
> > You're basically requesting explicit permission for any "non-official"
> > tags as well, including reviewed-by. This is not what it is wanted here.  
> 
> Ahh, okay, I see the problem now. But well, I'd say "as all except" in a
> text like this implicitly only refers to those the text mentions in the
> first place. So I'd say it's good as it is. But if people think this is
> a problem,

I still think it is problematic, but with the change below:

> I could easily use a slightly modified phrase like "...as all
> mentioned above except...".

It seems a lot better to me.

Regards,
Mauro

  reply	other threads:[~2024-12-02 16:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02  8:14 Thorsten Leemhuis
2024-12-02  8:28 ` Mauro Carvalho Chehab
2024-12-02 10:02   ` Mauro Carvalho Chehab
2024-12-02 13:54     ` Thorsten Leemhuis
2024-12-02 14:45       ` Mauro Carvalho Chehab
2024-12-02 15:54         ` Thorsten Leemhuis
2024-12-02 16:17           ` Mauro Carvalho Chehab [this message]
2024-12-03  6:25             ` Thorsten Leemhuis
2024-12-03  6:59               ` Mauro Carvalho Chehab
2024-12-04  1:06 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241202171734.2874a9a3@foz.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=simona.vetter@ffwll.ch \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox