workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	linux-media@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	workflows@vger.kernel.org, Hans Verkuil <hverkuil@xs4ll.nl>
Subject: Re: [PATCH] docs: media: document media multi-committers rules and process
Date: Thu, 28 Nov 2024 11:31:43 +0200	[thread overview]
Message-ID: <20241128093143.GB13800@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20241128091959.7ddeec08@foz.lan>

On Thu, Nov 28, 2024 at 09:19:59AM +0100, Mauro Carvalho Chehab wrote:
> Em Wed, 27 Nov 2024 12:59:58 +0100 Hans Verkuil escreveu:
> 
> > > I find the GPG signature requirement to be borderline ridiculous. The
> > > first message you're giving to committers is that you distrust them so
> > > much that you want them to sign an agreement with their blood
> > > (figuratively speaking). I don't think it's a very good approach to
> > > community building, nor does it bring any advantage to anyone.  
> > 
> > I kind of agree with Laurent here. Is the media-committers mailinglist
> > publicly archived somewhere? I think it is sufficient if this is posted
> > to a publicly archived mailinglist. That could be linux-media, I would be
> > fine with that. But media-committers would be more appropriate, but only
> > if it is archived somewhere.
> > 
> > If we want a GPG key, what would we do with it anyway?
> 
> Every time I send pull requests upstream, I sign the PR tag with my GPG 
> key:
> 
> 	https://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media.git/tag/?h=media/v6.13-2
> 
> This is a requirement from the top maintainer. Requiring it is pretty much 
> standard at the Kernel community, and wasn't anything similar "to sign with 
> my blood" (using your words).
> 
> It is not just a random GPG key: it is a trusted key as stated at this patch:
> 
> 	"a PGP key cross signed by other Kernel and media developers"
> 	 ...
> 	 For more details about PGP sign, please read 
> 	 Documentation/process/maintainer-pgp-guide.rst and
> 	 :ref:`kernel_org_trust_repository`."
> 
> If you see the last link, we're talking about a GPG signature inside
> kernel.org web of trust.
> 
> Heh, all PRs we receive are signed with GPG keys that we trust, including
> PRs from you. We need to keep doing it with the new workflow.
> 
> That reminds that there are still a gap there: the e-mail from the 
> newcoming committer shall contain something like:
> 
> 	"I'll be using this username to commit patches at media-committers:
> 	 https://gitlab.freedesktop.org/<username>"
> 
> I'll add it to the next version.

I don't mind much either way, but as we're using gitlab for the shared
tree, we could also do the same as drm-misc and handle this through a
gitlab issue instead of an e-mail. That advantage is that we'll ensure
the person has a gitlab account.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2024-11-28  9:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 13:28 Mauro Carvalho Chehab
2024-11-26 15:19 ` Laurent Pinchart
2024-11-27  9:39   ` Mauro Carvalho Chehab
2024-11-27 11:19     ` Laurent Pinchart
2024-11-27 14:48       ` Simona Vetter
2024-11-28 11:24         ` Jani Nikula
2024-11-28 18:47           ` Mauro Carvalho Chehab
2024-11-28 21:27             ` Jani Nikula
2024-11-28 21:52               ` Simona Vetter
2024-11-29  2:21                 ` Mauro Carvalho Chehab
2024-11-29  1:57               ` Mauro Carvalho Chehab
2024-11-28 18:28         ` Mauro Carvalho Chehab
2024-11-28 19:08           ` Laurent Pinchart
2024-11-27 11:54     ` Mauro Carvalho Chehab
2024-11-27 13:39       ` Laurent Pinchart
2024-11-27 15:09         ` Mauro Carvalho Chehab
2024-11-27 17:59           ` Laurent Pinchart
2024-11-27 11:59   ` Hans Verkuil
2024-11-27 13:25     ` Laurent Pinchart
2024-11-28 18:15       ` Mauro Carvalho Chehab
2024-11-28 19:07         ` Laurent Pinchart
2024-11-29 10:29           ` Mauro Carvalho Chehab
2024-12-02 10:24             ` Laurent Pinchart
2024-11-28  8:19     ` Mauro Carvalho Chehab
2024-11-28  9:31       ` Laurent Pinchart [this message]
2024-11-28 17:44     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241128093143.GB13800@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=corbet@lwn.net \
    --cc=hverkuil@xs4all.nl \
    --cc=hverkuil@xs4ll.nl \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox