From: Nathan Chancellor <nathan@kernel.org>
To: Rong Xu <xur@google.com>
Cc: Alice Ryhl <aliceryhl@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Bill Wendling <morbo@google.com>,
Borislav Petkov <bp@alien8.de>, Breno Leitao <leitao@debian.org>,
Brian Gerst <brgerst@gmail.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
David Li <davidxl@google.com>, Han Shen <shenhan@google.com>,
Heiko Carstens <hca@linux.ibm.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Jann Horn <jannh@google.com>, Jonathan Corbet <corbet@lwn.net>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Juergen Gross <jgross@suse.com>,
Justin Stitt <justinstitt@google.com>,
Kees Cook <kees@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
"Mike Rapoport (IBM)" <rppt@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>,
"Paul E. McKenney" <paulmck@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Sami Tolvanen <samitolvanen@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Wei Yang <richard.weiyang@gmail.com>,
workflows@vger.kernel.org,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Maksim Panchenko <max4bolt@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
Yonghong Song <yonghong.song@linux.dev>,
Yabin Cui <yabinc@google.com>,
Krzysztof Pszeniczny <kpszeniczny@google.com>,
Sriraman Tallam <tmsriram@google.com>,
Stephane Eranian <eranian@google.com>,
x86@kernel.org, linux-arch@vger.kernel.org,
sparclinux@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v7 7/7] Add Propeller configuration for kernel build
Date: Thu, 7 Nov 2024 13:45:04 -0700 [thread overview]
Message-ID: <20241107204504.GA3432398@thelio-3990X> (raw)
In-Reply-To: <20241102175115.1769468-8-xur@google.com>
Hi Rong,
On Sat, Nov 02, 2024 at 10:51:14AM -0700, Rong Xu wrote:
> diff --git a/scripts/Makefile.propeller b/scripts/Makefile.propeller
> new file mode 100644
> index 0000000000000..344190717e471
> --- /dev/null
> +++ b/scripts/Makefile.propeller
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +# Enable available and selected Clang Propeller features.
> +ifdef CLANG_PROPELLER_PROFILE_PREFIX
> + CFLAGS_PROPELLER_CLANG := -fbasic-block-sections=list=$(CLANG_PROPELLER_PROFILE_PREFIX)_cc_profile.txt -ffunction-sections
> + KBUILD_LDFLAGS += --symbol-ordering-file=$(CLANG_PROPELLER_PROFILE_PREFIX)_ld_profile.txt --no-warn-symbol-ordering
> +else
> + CFLAGS_PROPELLER_CLANG := -fbasic-block-sections=labels
> +endif
It appears that '-fbasic-block-sections=labels' has been deprecated in
the main branch of LLVM, as I see a warning repeated over and over when
building allmodconfig:
clang: warning: argument '-fbasic-block-sections=labels' is deprecated, use '-fbasic-block-address-map' instead [-Wdeprecated]
https://github.com/llvm/llvm-project/commit/7b7747dc1d3da1a829503ea9505b4cecce4f5bda
Sorry that I missed this during testing, as I was only using clang-19 at
the time.
I think you can send a fixup on top of Masahiro's branch:
https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/log/?h=kbuild
> +# Propeller requires debug information to embed module names in the profiles.
> +# If CONFIG_DEBUG_INFO is not enabled, set -gmlt option. Skip this for AutoFDO,
> +# as the option should already be set.
> +ifndef CONFIG_DEBUG_INFO
> + ifndef CONFIG_AUTOFDO_CLANG
> + CFLAGS_PROPELLER_CLANG += -gmlt
> + endif
> +endif
> +
> +ifdef CONFIG_LTO_CLANG_THIN
> + ifdef CLANG_PROPELLER_PROFILE_PREFIX
> + KBUILD_LDFLAGS += --lto-basic-block-sections=$(CLANG_PROPELLER_PROFILE_PREFIX)_cc_profile.txt
> + else
> + KBUILD_LDFLAGS += --lto-basic-block-sections=labels
I think this might have a similar problem but I have not tested.
> + endif
> +endif
> +
> +export CFLAGS_PROPELLER_CLANG
Cheers,
Nathan
next prev parent reply other threads:[~2024-11-07 20:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-02 17:51 [PATCH v7 0/7] Add AutoFDO and Propeller support for Clang build Rong Xu
2024-11-02 17:51 ` [PATCH v7 1/7] Add AutoFDO " Rong Xu
2024-11-02 19:46 ` Peter Jung
2024-11-02 19:53 ` Peter Jung
2024-11-04 4:50 ` Han Shen
2024-11-04 16:05 ` Peter Jung
2024-11-04 17:30 ` Peter Jung
2024-11-04 20:24 ` Han Shen
2024-11-05 7:25 ` Rong Xu
2024-11-05 14:33 ` Peter Jung
2024-11-05 14:56 ` Peter Jung
2024-11-05 17:19 ` Peter Jung
2024-11-05 17:51 ` Rong Xu
2024-11-02 17:51 ` [PATCH v7 2/7] objtool: Fix unreachable instruction warnings for weak functions Rong Xu
2024-11-02 17:51 ` [PATCH v7 3/7] Adjust symbol ordering in text output section Rong Xu
2024-12-01 14:31 ` [PATCH v7 3/7] Adjust symbol ordering in text output section [openrisc boot failure] Guenter Roeck
2024-12-02 6:39 ` Masahiro Yamada
2024-11-02 17:51 ` [PATCH v7 4/7] Add markers for text_unlikely and text_hot sections Rong Xu
2024-11-02 17:51 ` [PATCH v7 5/7] AutoFDO: Enable -ffunction-sections for the AutoFDO build Rong Xu
2024-11-02 17:51 ` [PATCH v7 6/7] AutoFDO: Enable machine function split optimization for AutoFDO Rong Xu
2024-11-02 17:51 ` [PATCH v7 7/7] Add Propeller configuration for kernel build Rong Xu
2024-11-07 20:45 ` Nathan Chancellor [this message]
2024-11-07 21:54 ` Rong Xu
2024-12-12 21:20 ` Yonghong Song
2024-12-12 21:34 ` Nathan Chancellor
2024-12-12 22:03 ` Rong Xu
2024-11-06 16:08 ` [PATCH v7 0/7] Add AutoFDO and Propeller support for Clang build Masahiro Yamada
2024-11-06 19:00 ` Rong Xu
2024-11-07 14:57 ` Masahiro Yamada
2024-11-07 18:44 ` Rong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107204504.GA3432398@thelio-3990X \
--to=nathan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=andreas@gaisler.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=davidxl@google.com \
--cc=eranian@google.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=jgross@suse.com \
--cc=jpoimboe@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=kpszeniczny@google.com \
--cc=leitao@debian.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=max4bolt@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=richard.weiyang@gmail.com \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=shenhan@google.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tmsriram@google.com \
--cc=workflows@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xur@google.com \
--cc=yabinc@google.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox