workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Rong Xu <xur@google.com>
Cc: Alice Ryhl <aliceryhl@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Bill Wendling <morbo@google.com>,
	Borislav Petkov <bp@alien8.de>, Breno Leitao <leitao@debian.org>,
	Brian Gerst <brgerst@gmail.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	David Li <davidxl@google.com>, Han Shen <shenhan@google.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Jann Horn <jannh@google.com>, Jonathan Corbet <corbet@lwn.net>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Justin Stitt <justinstitt@google.com>,
	Kees Cook <kees@kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	"Mike Rapoport (IBM)" <rppt@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nicolas Schier <nicolas@fjasle.eu>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Wei Yang <richard.weiyang@gmail.com>,
	workflows@vger.kernel.org,
	Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	Maksim Panchenko <max4bolt@gmail.com>,
	Yonghong Song <yonghong.song@linux.dev>,
	Yabin Cui <yabinc@google.com>,
	x86@kernel.org, linux-arch@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v4 0/6] Add AutoFDO and Propeller support for Clang build
Date: Sat, 19 Oct 2024 20:25:23 -0700	[thread overview]
Message-ID: <20241020032523.GA3652325@thelio-3990X> (raw)
In-Reply-To: <CAF1bQ=SQ9rFdwRk_waQvn4PW7x6T1uJmJ8qNqj04oRKmujkCQw@mail.gmail.com>

Hi Rong,

On Fri, Oct 18, 2024 at 11:20:02PM -0700, Rong Xu wrote:
> Thanks to all for the feedback and suggestions! We are ready to make any further
> changes needed. Is there anything else we can address for this patch?

I will reply in a separate thread for visibility but I think one of the
biggest open questions at the moment is trying to find someone to
shepherd this code into mainline.

> Also, we know it's not easy to test this patch, but if anyone has had a chance
> to try building AutoFDO/Propeller kernels with it, we'd really appreciate your
> input here. Any confirmation that it works as expected would be very helpful.

I went to take this series for a spin in a virtual machine first as a
smoke test before attempting to boot on bare metal. This was done on a
server with an Intel Xeon Gold 6314U. The kernel booted fine but when I
went to run the command to generate the perf data from the
documentation, I get an error.

  $ perf record -e BR_INST_RETIRED.NEAR_TAKEN:k -a -N -b -c 500009 -o /tmp/perf.data -- make -j$(nproc) O=out mrproper defconfig all
  Error:
  BR_INST_RETIRED.NEAR_TAKEN:k: PMU Hardware or event type doesn't support branch stack sampling.

Do you know if this is expected for a virtual machine setup? I will
attempt to test the series on real hardware here soon, it is currently
tied up with investigating a regression in -next at the moment.

Cheers,
Nathan

  parent reply	other threads:[~2024-10-20  3:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14 21:33 Rong Xu
2024-10-14 21:33 ` [PATCH v4 1/6] Add AutoFDO " Rong Xu
2024-10-20 16:32   ` Masahiro Yamada
2024-10-21 22:43     ` Rong Xu
2024-10-23  6:44       ` Masahiro Yamada
2024-10-14 21:33 ` [PATCH v4 2/6] objtool: Fix unreachable instruction warnings for weak funcitons Rong Xu
2024-10-14 21:33 ` [PATCH v4 3/6] Change the symbols order when --ffuntion-sections is enabled Rong Xu
2024-10-21  2:15   ` Masahiro Yamada
2024-10-21 23:43     ` Rong Xu
2024-10-23  6:48       ` Masahiro Yamada
2024-10-14 21:33 ` [PATCH v4 4/6] AutoFDO: Enable -ffunction-sections for the AutoFDO build Rong Xu
2024-10-21  2:25   ` Masahiro Yamada
2024-10-21 23:32     ` Rong Xu
2024-10-23  6:49       ` Masahiro Yamada
2024-10-14 21:33 ` [PATCH v4 5/6] AutoFDO: Enable machine function split optimization for AutoFDO Rong Xu
2024-10-21  3:18   ` Masahiro Yamada
2024-10-21 23:28     ` Rong Xu
2024-10-23  6:49       ` Masahiro Yamada
2024-10-23 16:24         ` Rong Xu
2024-10-14 21:33 ` [PATCH v4 6/6] Add Propeller configuration for kernel build Rong Xu
2024-10-20 17:48   ` Masahiro Yamada
2024-10-22  0:00     ` Rong Xu
2024-10-23  7:06       ` Masahiro Yamada
2024-10-23  7:25         ` Arnd Bergmann
2024-10-23  7:28           ` Masahiro Yamada
2024-10-23 16:23             ` Rong Xu
2024-10-19  6:20 ` [PATCH v4 0/6] Add AutoFDO and Propeller support for Clang build Rong Xu
2024-10-20  3:20   ` Yonghong Song
2024-10-20  3:25   ` Nathan Chancellor [this message]
2024-10-21 21:12     ` Rong Xu
2024-10-20  3:31 ` Nathan Chancellor
2024-10-20 15:45   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241020032523.GA3652325@thelio-3990X \
    --to=nathan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=davidxl@google.com \
    --cc=hca@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=jannh@google.com \
    --cc=jgross@suse.com \
    --cc=jpoimboe@kernel.org \
    --cc=justinstitt@google.com \
    --cc=kees@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=masahiroy@kernel.org \
    --cc=max4bolt@gmail.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mingo@redhat.com \
    --cc=morbo@google.com \
    --cc=ndesaulniers@google.com \
    --cc=nicolas@fjasle.eu \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=richard.weiyang@gmail.com \
    --cc=rppt@kernel.org \
    --cc=samitolvanen@google.com \
    --cc=shenhan@google.com \
    --cc=tglx@linutronix.de \
    --cc=workflows@vger.kernel.org \
    --cc=x86@kernel.org \
    --cc=xur@google.com \
    --cc=yabinc@google.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox