workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Justin Stitt <justinstitt@google.com>
Cc: Kees Cook <kees@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Rong Xu <xur@google.com>, Han Shen <shenhan@google.com>,
	Sriraman Tallam <tmsriram@google.com>,
	David Li <davidxl@google.com>,
	Krzysztof Pszeniczny <kpszeniczny@google.com>,
	Alice Ryhl <aliceryhl@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Bill Wendling <morbo@google.com>,
	Borislav Petkov <bp@alien8.de>, Breno Leitao <leitao@debian.org>,
	Brian Gerst <brgerst@gmail.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Jann Horn <jannh@google.com>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	linux-arch@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev, Masahiro Yamada <masahiroy@kernel.org>,
	"Mike Rapoport (IBM)" <rppt@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nicolas@fjasle.eu>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Samuel Holland <samuel.holland@sifive.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Wei Yang <richard.weiyang@gmail.com>,
	workflows@vger.kernel.org, x86@kernel.org,
	"Xin Li (Intel)" <xin@zytor.com>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v2 1/6] Add AutoFDO support for Clang build
Date: Sat, 5 Oct 2024 11:19:32 +0200	[thread overview]
Message-ID: <20241005091932.GW18071@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAFhGd8rPLoufNx4BMV993c+S_6psLGU6Ow49Frc9s88cStcuCQ@mail.gmail.com>

On Fri, Oct 04, 2024 at 02:23:45PM -0700, Justin Stitt wrote:
> On Fri, Oct 4, 2024 at 11:29 AM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Fri, Oct 04, 2024 at 11:10:04AM -0700, Kees Cook wrote:
> >
> > > +Configure the kernel with::(make)
> > > +
> > > +     CONFIG_AUTOFDO_CLANG=y
> > >
> > > Then we could avoid the extra 2 lines but still gain the rendered language
> > > highlights?
> >
> > The whole double-colon thing is already a pain to read; you're making it
> > worse again.
> 
> Lots of people read docs on the web and having code blocks with
> monospaced fonts (+syntax highlighting) makes them easier to read
> there.
> 
> Configure the kernel with:
> 
>      CONFIG_AUTOFDO_CLANG=y
> 
> --versus--
> 
> Configure the kernel with::
> 
>      CONFIG_AUTOFDO_CLANG=y
> 
> This renders better for html through Sphinx and really can't be that
> bad to read in vim, can it?

It's weird; but I've gotten sorta used to it. I was more or less
commenting on Kees' proposal of making it:

  Configure the kernel with::(make)

Which is definitely harder to read since it insta triggers a syntax
error exception in my head.

  reply	other threads:[~2024-10-05  9:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-02 23:33 [PATCH v2 0/6] Add AutoFDO and Propeller " Rong Xu
2024-10-02 23:34 ` [PATCH v2 1/6] Add AutoFDO " Rong Xu
2024-10-03 15:41   ` Peter Zijlstra
2024-10-03 15:51     ` Nick Desaulniers
2024-10-03 16:03       ` Peter Zijlstra
2024-10-03 16:11         ` Nick Desaulniers
2024-10-03 16:12           ` Peter Zijlstra
2024-10-03 18:20             ` Rong Xu
2024-10-04  6:06               ` Mike Rapoport
2024-10-04 16:28                 ` Rong Xu
2024-10-04 16:35                   ` Mike Rapoport
2024-10-04 17:06                     ` Rong Xu
2024-10-04 18:10     ` Kees Cook
2024-10-04 18:28       ` Peter Zijlstra
2024-10-04 21:23         ` Justin Stitt
2024-10-05  9:19           ` Peter Zijlstra [this message]
2024-10-05 14:42       ` Jonathan Corbet
2024-10-07 18:02         ` Rong Xu
2024-10-07 18:33           ` Miguel Ojeda
2024-10-07 19:21             ` Rong Xu
2024-10-02 23:34 ` [PATCH v2 2/6] objtool: Fix unreachable instruction warnings for weak funcitons Rong Xu
2024-10-02 23:34 ` [PATCH v2 3/6] Change the symbols order when --ffuntion-sections is enabled Rong Xu
2024-10-03 15:43   ` Peter Zijlstra
2024-10-03 18:12     ` Rong Xu
2024-10-02 23:34 ` [PATCH v2 4/6] AutoFDO: Enable -ffunction-sections for the AutoFDO build Rong Xu
2024-10-02 23:34 ` [PATCH v2 5/6] AutoFDO: Enable machine function split optimization for AutoFDO Rong Xu
2024-10-02 23:34 ` [PATCH v2 6/6] Add Propeller configuration for kernel build Rong Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241005091932.GW18071@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=davidxl@google.com \
    --cc=eranian@google.com \
    --cc=hca@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=jannh@google.com \
    --cc=jgross@suse.com \
    --cc=jpoimboe@kernel.org \
    --cc=justinstitt@google.com \
    --cc=kees@kernel.org \
    --cc=kpszeniczny@google.com \
    --cc=leitao@debian.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=masahiroy@kernel.org \
    --cc=mingo@redhat.com \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nicolas@fjasle.eu \
    --cc=paulmck@kernel.org \
    --cc=richard.weiyang@gmail.com \
    --cc=rppt@kernel.org \
    --cc=samuel.holland@sifive.com \
    --cc=shenhan@google.com \
    --cc=tglx@linutronix.de \
    --cc=tmsriram@google.com \
    --cc=workflows@vger.kernel.org \
    --cc=x86@kernel.org \
    --cc=xin@zytor.com \
    --cc=xur@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox