* Are multiple Fixes Tags OK?
@ 2024-09-19 15:07 Jeff Johnson
2024-09-21 9:08 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Johnson @ 2024-09-19 15:07 UTC (permalink / raw)
To: workflows
I'm reviewing an internal change that is fixing a memory leak of the same
object in two different error paths. However each of the two error paths were
introduced in separate commits, so there would be two Fixes: tags if both of
these are fixed with the same patch.
So is there any guidance on whether this should be one or two patches?
/jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Are multiple Fixes Tags OK?
2024-09-19 15:07 Are multiple Fixes Tags OK? Jeff Johnson
@ 2024-09-21 9:08 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2024-09-21 9:08 UTC (permalink / raw)
To: Jeff Johnson; +Cc: workflows
On Thu, Sep 19, 2024 at 08:07:56AM -0700, Jeff Johnson wrote:
> I'm reviewing an internal change that is fixing a memory leak of the same
> object in two different error paths. However each of the two error paths were
> introduced in separate commits, so there would be two Fixes: tags if both of
> these are fixed with the same patch.
>
> So is there any guidance on whether this should be one or two patches?
Ideally 2, if it's two different changes in the diff. But we have
patches with multiple Fixes: tags all the time, it's not unusual and if
it works for you, no objection.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-21 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-19 15:07 Are multiple Fixes Tags OK? Jeff Johnson
2024-09-21 9:08 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox