workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Thorsten Leemhuis <linux@leemhuis.info>,
	helpdesk@kernel.org,
	 "workflows@vger.kernel.org" <workflows@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Please create the email alias do-not-apply-to-stable@kernel.org -> /dev/null
Date: Wed, 17 Apr 2024 09:55:52 -0400	[thread overview]
Message-ID: <20240417-spectral-doberman-of-prosperity-d2c0cc@lemur> (raw)
In-Reply-To: <2024041734-gleeful-freewill-b24b@gregkh>

On Wed, Apr 17, 2024 at 03:38:28PM +0200, Greg KH wrote:
> > That afaics makes them useless for the stable team (Greg may correct 
> > me
> > if I'm wrong here), as they deal with the commits and have no easy,
> > fast, and reliable way to look up the patch posting to query this. Or is
> > the "patch basement" available somehow in git for each commit and I just
> > missed that?
> 
> You are correct, as-is, that would make it useless for my tools.
> 
> BUT I could, if it's possible, just look up the original in lore somehow
> and parse that.  If it's there, does anyone have a "simple" way to map a
> git commit back to a lore message if it does NOT have a Link: line in
> it?

Our current way of doing it is going by patch-id, and it's not great 
either, because there is more than one way to create a patch from a git 
commit. We've discovered this when Linus recommended that people send 
patches with the --histogram algorithm, which broke a bunch of our 
stuff. :)

E.g. here's a recent commit that has a Fixes:

  git show c0297e7dd50795d559f3534887a6de1756b35d0f | git patch-id --stable | cut -d' ' -f1
  c2f5c42a5a3bc05ffacd9679dd367e4a2207b018

it successfully maps to the patch:
https://lore.kernel.org/all/?q=patchid%3Ac2f5c42a5a3bc05ffacd9679dd367e4a2207b018

I only put this here for academic purposes -- I really don't want you to 
go that route, because it's fragile (more fragile than git notes, and 
that's saying something).

-K

  reply	other threads:[~2024-04-17 13:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17  7:48 Thorsten Leemhuis
2024-04-17  7:55 ` Greg KH
2024-04-17  8:09 ` Mauro Carvalho Chehab
2024-04-17  8:16   ` Greg KH
2024-04-17  8:48     ` Willy Tarreau
2024-04-17 17:13       ` Florian Fainelli
2024-04-17 16:56     ` Mauro Carvalho Chehab
2024-04-17 12:52 ` Konstantin Ryabitsev
2024-04-17 13:15   ` Vlastimil Babka
2024-04-17 13:21   ` Thorsten Leemhuis
2024-04-17 13:25     ` Konstantin Ryabitsev
2024-04-17 13:38     ` Greg KH
2024-04-17 13:55       ` Konstantin Ryabitsev [this message]
2024-04-18  7:04       ` Thorsten Leemhuis
2024-04-18 13:20         ` Greg KH
2024-04-22 15:49           ` Thorsten Leemhuis
2024-04-22 19:25             ` Konstantin Ryabitsev
2024-04-22 21:46               ` Mauro Carvalho Chehab
2024-04-22 22:04                 ` Greg KH
2024-04-22 22:15                   ` Mauro Carvalho Chehab
2024-04-23  7:28                     ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240417-spectral-doberman-of-prosperity-d2c0cc@lemur \
    --to=konstantin@linuxfoundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=helpdesk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox