From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Barry Song <21cnbao@gmail.com>
Cc: corbet@lwn.net, workflows@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Barry Song <v-songbaohua@oppo.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Zankel <chris@zankel.net>,
Huacai Chen <chenhuacai@loongson.cn>,
Herbert Xu <herbert@gondor.apana.org.au>,
Guenter Roeck <linux@roeck-us.net>,
Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH] Documentation: coding-style: ask function-like macros to evaluate parameters
Date: Wed, 20 Mar 2024 12:42:07 +1100 [thread overview]
Message-ID: <20240320124207.0c127947@canb.auug.org.au> (raw)
In-Reply-To: <20240320001656.10075-1-21cnbao@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
Hi Barry,
On Wed, 20 Mar 2024 13:16:56 +1300 Barry Song <21cnbao@gmail.com> wrote:
>
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index 9c7cf7347394..8065747fddff 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -827,6 +827,13 @@ Macros with multiple statements should be enclosed in a do - while block:
> do_this(b, c); \
> } while (0)
>
> +Function-like macros should evaluate their parameters, for unused parameters,
> +cast them to void:
> +
> +.. code-block:: c
> +
> + #define macrofun(a) do { (void) (a); } while (0)
> +
Maybe add some comment about using a static inline function for these
simple versions instead, if at all possible, (it is suggested just
above this section) since that will still type check arguments.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-20 1:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 0:16 Barry Song
2024-03-20 1:42 ` Stephen Rothwell [this message]
2024-03-20 3:24 ` Barry Song
2024-03-20 3:45 ` Stephen Rothwell
2024-03-20 15:49 ` Andrew Morton
2024-03-20 18:48 ` Barry Song
2024-03-21 11:15 ` Mark Brown
2024-03-21 20:29 ` Barry Song
2024-03-21 17:44 ` Andrew Morton
2024-03-20 23:37 ` Meiyong Yu
2024-03-21 0:11 ` Barry Song
2024-03-21 4:38 ` Meiyong Yu
2024-03-21 7:42 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320124207.0c127947@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chenhuacai@loongson.cn \
--cc=chris@zankel.net \
--cc=corbet@lwn.net \
--cc=herbert@gondor.apana.org.au \
--cc=jcmvbkbc@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=v-songbaohua@oppo.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox