From: Jakub Kicinski <kuba@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Christian Marangi <ansuelsmth@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
David Epping <david.epping@missinglinkelectronics.com>,
Vladimir Oltean <olteanv@gmail.com>,
Harini Katakam <harini.katakam@amd.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
workflows@vger.kernel.org
Subject: Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write
Date: Tue, 5 Dec 2023 07:29:12 -0800 [thread overview]
Message-ID: <20231205072912.2d79a1d5@kernel.org> (raw)
In-Reply-To: <ZW89errbJWUt33vz@shell.armlinux.org.uk>
On Tue, 5 Dec 2023 15:10:50 +0000 Russell King (Oracle) wrote:
> I've raised this before in other subsystems, and it's suggested that
> it's better to have it in the .c file. I guess the reason is that it's
> more obvious that the function is documented when modifying it, so
> there's a higher probability that the kdoc will get updated when the
> function is altered.
Plus I think people using IDEs (i.e. not me) may use the "jump to
definition" functionality, to find the doc?
TBH I thought putting kdoc in the C source was documented in the coding
style, but I can't find any mention of it now.
next parent reply other threads:[~2023-12-05 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231128133630.7829-1-ansuelsmth@gmail.com>
[not found] ` <20231128133630.7829-3-ansuelsmth@gmail.com>
[not found] ` <20231204181752.2be3fd68@kernel.org>
[not found] ` <51aae9d0-5100-41af-ade0-ecebeccbc418@lunn.ch>
[not found] ` <656f37a6.5d0a0220.96144.356f@mx.google.com>
[not found] ` <adbe5299-de4a-4ac1-90d0-f7ae537287d0@lunn.ch>
[not found] ` <ZW89errbJWUt33vz@shell.armlinux.org.uk>
2023-12-05 15:29 ` Jakub Kicinski [this message]
2023-12-05 16:11 ` Russell King (Oracle)
2023-12-05 17:44 ` Jeff Johnson
2023-12-05 18:14 ` Russell King (Oracle)
2023-12-05 19:58 ` Jeff Johnson
2023-12-05 20:11 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205072912.2d79a1d5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=david.epping@missinglinkelectronics.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=harini.katakam@amd.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox