From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kees Cook <keescook@chromium.org>
Cc: Borislav Petkov <bp@alien8.de>, Jonathan Corbet <corbet@lwn.net>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] docs: submitting-patches: improve the base commit explanation
Date: Wed, 15 Nov 2023 19:56:32 +0200 [thread overview]
Message-ID: <20231115175632.GA29486@pendragon.ideasonboard.com> (raw)
In-Reply-To: <202311150948.F6E39AD@keescook>
On Wed, Nov 15, 2023 at 09:49:31AM -0800, Kees Cook wrote:
> On Wed, Nov 15, 2023 at 06:03:30PM +0100, Borislav Petkov wrote:
> > From: "Borislav Petkov (AMD)" <bp@alien8.de>
> >
> > After receiving a second patchset this week without knowing which tree
> > it applies on and trying to apply it on the obvious ones and failing,
> > make sure the base tree information which needs to be supplied in the
> > 0th message of the patchset is spelled out more explicitly.
> >
> > Also, make the formulations stronger as this really is a requirement and
> > not only a useful thing anymore.
> >
> > Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
>
> Yup, I wonder if making "--base=auto" a default in git might be a good
> idea too?
When the base of a series is in Linus' tree, or in the corresponding
subsystem maintainer's tree, things are easy, but there are many
situations where the base is a merge of multiple branches (perhaps a
for-next and a fixes branch for instance), or where prerequisites have
been applied manually for one reason or another. This can and should of
course be described in the cover letter, and the submitter should push
and provide a link to a branch that contains the series on top of the
appropriate base (or just a link to the base). This won't help the bots
much though, if they just look at the base tag. Is there a way, or can
we standardize on a way, to indicate where the base can be found ?
> Reviewed-by: Kees Cook <keescook@chromium.org>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-11-15 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 17:03 Borislav Petkov
2023-11-15 17:49 ` Kees Cook
2023-11-15 17:56 ` Laurent Pinchart [this message]
2023-11-15 18:22 ` Konstantin Ryabitsev
2023-11-15 18:07 ` Borislav Petkov
2023-11-27 17:53 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115175632.GA29486@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox