From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A30E6C0015E for ; Wed, 26 Jul 2023 21:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229600AbjGZV5Z (ORCPT ); Wed, 26 Jul 2023 17:57:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbjGZV5Y (ORCPT ); Wed, 26 Jul 2023 17:57:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56EA21985 for ; Wed, 26 Jul 2023 14:57:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC5D661CC5 for ; Wed, 26 Jul 2023 21:57:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DB31C433C7; Wed, 26 Jul 2023 21:57:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690408642; bh=tAlkFh8lTCa8bL32N8xgDfGEtzco/lV9MYjctWZA4+U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VBRKPcqX/JaPGrEj1BXBVAJFPPa2Ymb/SPsNhcVKtUwQm458GgI/X0Gv4YRtUD9bv +fw87Qb2DqQ5zrZbWkWO59+EOYckfsRKTMpXtlHAXoSdMgeKLPR4vsJLdKhhnkG0XS VqFKM13VhqxqjZdKH28wHpVre9C68XK3UkEQlBXrqfftMWvUgXsX4S/E2Ck972Zfwa XA3IE3R1Izl93IguTTz559kn8jjfZlMtpIpxjwo41eINePyA3/q5BbbF17YX5UvGdd amxBqdVOSjvYEGNRKEfdhC4Ovo7sE08IUQsJlHYXzR3E0Vx8J5CCJdEKMCstUwZA6A Sbtar2vcyC9ew== Date: Wed, 26 Jul 2023 14:57:21 -0700 From: Jakub Kicinski To: Linus Torvalds Cc: Joe Perches , Krzysztof Kozlowski , geert@linux-m68k.org, gregkh@linuxfoundation.org, netdev@vger.kernel.org, workflows@vger.kernel.org, mario.limonciello@amd.com Subject: Re: [PATCH v2] scripts: get_maintainer: steer people away from using file paths Message-ID: <20230726145721.52a20cb7@kernel.org> In-Reply-To: References: <20230726151515.1650519-1-kuba@kernel.org> <11ec5b3819ff17c7013348b766eab571eee5ca96.camel@perches.com> <20230726092312.799503d6@kernel.org> <20230726112031.61bd0c62@kernel.org> <20230726114817.1bd52d48@kernel.org> <20230726130318.099f96fc@kernel.org> <20230726133648.54277d76@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: workflows@vger.kernel.org On Wed, 26 Jul 2023 14:07:28 -0700 Linus Torvalds wrote: > On Wed, 26 Jul 2023 at 13:36, Jakub Kicinski wrote: > > > > Just so I fully understand what you're saying - what do you expect me > > to do? Send the developer a notifications saying "please repost" with > > this CC list? How is that preferable to making them do it right the > > first time?! > > Not at all. > > The whole point is that you already end up relying on scripting to > notice that some people should be cc'd, so just add them > automatically. > > Why would you > > (a) waste your own time asking the original developer to re-do his submission > > (b) ask the original developer to do something that clearly long-time > developers don't do > > (c) waste *everybody's* time re-submitting a change that was detected > automatically and could just have been done automatically in the first > place? > > just make patchwork add the cc's automatically to the patch - and send > out emails to the people it added. > > Patchwork already sends out emails for other things. Guess how I know? > Because I get the patchwork-bot emails all the time for things I have > been cc'd on. Including, very much, the netdevbpf ones. > > And people who don't want to be notified can already register with > patchwork to not be notified. It's right there in that > > Deet-doot-dot, I am a bot. > https://korg.docs.kernel.org/patchwork/pwbot.html > > footer. > > So I would literally suggest you just stop asking people to do things > that automation CAN DO BETTER. > > The patchwork notification could be just a small note (the same way > the pull request notes are) that point to the submission, and say > "your name has been added to the Cc for this patch because it claims > to fix something you authored or acked". Lots of those will be false positives, and also I do not want to sign up to maintain a bot which actively bothers people. And have every other subsystem replicate something of that nature. Sidebar, but IMO we should work on lore to create a way to *subscribe* to patches based on paths without running any local agents. But if I can't explain how get_maintainers is misused I'm sure I'll have a lot of luck explaining that one :D > See what I'm saying? Why are you wasting your time on this? Why are > you making new developers do pointless stuff that is better done by a > script, since you're just asking the developer to run a script in the > first place? For the last time, most people already run get_maintainer, they just choose the wrong "mode" of running it for the use case. I am not trying to make anyone do anything they aren't already doing. > You are just wasting literally EVERYBODY'S time with your workflow > rules. For no actual advantage, since the whole - and only - point of > this all was that it was scriptable, and is in fact already being > scripted, which is how you even notice the issue in the first place. And it has nothing to do with *my* workflow. Unless you're arguing that asking for authors of patches which Fixes points to is part of "my" workflow and nobody else's. > You seem to be just overly attached to having people waste their time > on running a script that you run automatically *anyway*, and make that > some "required thing for inexperienced developers". I said "for the last time" so I won't repeat... > And it can't even be the right thing to do, when experienced > developers don't do it. I explained to you already that Florian's posting is a PR.