From: Jakub Kicinski <kuba@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
geert@linux-m68k.org, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, workflows@vger.kernel.org,
mario.limonciello@amd.com
Subject: Re: [PATCH v2] scripts: get_maintainer: steer people away from using file paths
Date: Wed, 26 Jul 2023 13:03:18 -0700 [thread overview]
Message-ID: <20230726130318.099f96fc@kernel.org> (raw)
In-Reply-To: <CAHk-=whCE9cWmTXu54WFQ7x-aH8n=dhCux2h49=pYN=14ybkxg@mail.gmail.com>
On Wed, 26 Jul 2023 12:37:14 -0700 Linus Torvalds wrote:
> The very first case I actually looked at wasn't even some
> "inexperienced developer" - the kind you claim is the problem, and the
> kind you claim this would help.
>
> It was a random fix from Florian Westphal, who has been around for
> more than a decade, is credited with over 1500 commits (and mentioned
> in many many more), and knows what he's doing.
>
> He has a patch that references a "Fixes:" line, and clearly didn't go
> through the get_maintainer script as such, and the
> netdev/cc_maintainers script complains as a result.
Florian is sending us patches from his tree which have already been
reviewed on the netfilter mailing list. It's basically a PR.
There's a handful of people who do that and I don't care enough to
silence it because ignoring the false positives is a noop.
When some noob sends a patch which actually *should* have been CCed
to more people I need to either go and CC that person in myself.
Or tell the noob to repost.
IOW solving the _actually_ missing CCs is higher priority for me.
> So Jakub, I think you are barking *entirely* up the wrong tree.
>
> The reason you blame this on mis-use by inexperienced maintainers is
> that you probably never even react to the experienced ones that do the
> very same things, because you trust them and never bother to tell them
> "you didn't use get_maintainers to get the precise list of people that
> patchwork complains about".
>
> So the problem is not in get_maintainers. It's in having expectations
> that are simply not realistic.
>
> You seem to think that those inexperienced developers should do something that
>
> (a) experienced developers don't do *EITHER*
>
> (b) the scripts complain about instead of just doing
>
> and then you think that changing get_maintainers would somehow hide the issue.
>
> You definitely shouldn't require inexperienced developers to do
> something that clearly experienced people then don't do.
>
> Now, maybe I happened to just randomly pick a patchwork entry that was
> very unusual. But I doubt it.
next prev parent reply other threads:[~2023-07-26 20:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 15:15 Jakub Kicinski
2023-07-26 15:20 ` Mario Limonciello
2023-07-26 15:43 ` Joe Perches
2023-07-26 16:23 ` Jakub Kicinski
2023-07-26 16:45 ` Linus Torvalds
2023-07-26 16:51 ` Joe Perches
2023-07-26 18:20 ` Jakub Kicinski
2023-07-26 18:29 ` Linus Torvalds
2023-07-26 18:45 ` Limonciello, Mario
2023-07-26 18:48 ` Linus Torvalds
2023-07-26 18:48 ` Jakub Kicinski
2023-07-26 18:59 ` Linus Torvalds
2023-07-26 19:05 ` Linus Torvalds
2023-07-26 19:37 ` Linus Torvalds
2023-07-26 20:03 ` Jakub Kicinski [this message]
2023-07-26 20:13 ` Linus Torvalds
2023-07-26 20:36 ` Jakub Kicinski
2023-07-26 21:07 ` Linus Torvalds
2023-07-26 21:57 ` Jakub Kicinski
2023-07-26 22:02 ` Linus Torvalds
2023-07-26 22:15 ` Linus Torvalds
2023-07-26 23:47 ` Konstantin Ryabitsev
2023-07-27 0:11 ` Jakub Kicinski
2023-07-27 0:24 ` Konstantin Ryabitsev
2023-07-27 0:27 ` Jakub Kicinski
2023-07-27 0:33 ` Konstantin Ryabitsev
2023-07-27 1:07 ` Joe Perches
2023-07-27 11:00 ` Andrew Lunn
2023-07-28 20:29 ` Konstantin Ryabitsev
2023-07-28 20:38 ` Jakub Kicinski
2023-07-28 20:50 ` Konstantin Ryabitsev
2023-07-29 0:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726130318.099f96fc@kernel.org \
--to=kuba@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=mario.limonciello@amd.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox