workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	geert@linux-m68k.org, gregkh@linuxfoundation.org,
	netdev@vger.kernel.org, workflows@vger.kernel.org,
	mario.limonciello@amd.com
Subject: Re: [PATCH v2] scripts: get_maintainer: steer people away from using file paths
Date: Wed, 26 Jul 2023 11:20:31 -0700	[thread overview]
Message-ID: <20230726112031.61bd0c62@kernel.org> (raw)
In-Reply-To: <CAHk-=wjEj2fGiaQXrYUZu65EPdgbGEAEMzch8LTtiUp6UveRCw@mail.gmail.com>

On Wed, 26 Jul 2023 09:45:25 -0700 Linus Torvalds wrote:
> On Wed, 26 Jul 2023 at 09:23, Jakub Kicinski <kuba@kernel.org> wrote:
> > > Nack on that bit.
> > > My recollection is it's Linus' preferred mechanism.  
> >
> > Let Linus speak for himself, hopefully he's okay with throwing
> > in the -f.  
> 
> It's not the '-f' that would be the problem - that's how the script
> used to work long ago, and I still occasionally end up adding the -f
> by habit.
> 
> So removing the auto-guessing of file paths wouldn't be a problem.
> 
> But the annoying warning is wrong.
> 
> I use get_maintainers all the time, and I *only* use it for file
> paths. If I know the commit, I get the list of people from the commit
> itself, so why should I *ever* use that script if I have a patch?

You are special, you presumably use it to find who to report
regressions to, and who to pull into conversations.

This tool is primarily used by _developers_ to find _maintainers_.
I mean *thousands* of developers use it every release to send their
patches.

The tool needs to see the commit message to fish out Fixes tags.

> So the whole "use of get_maintainers is only for patches, and we
> should warn about file paths" is insane.

Hrmpf, hrmpf.

> No. If I get that patch, I will remove the warning. The *only* reason
> for me to ever use that script is for the file path lookup.
> 
>              Linus


  parent reply	other threads:[~2023-07-26 18:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 15:15 Jakub Kicinski
2023-07-26 15:20 ` Mario Limonciello
2023-07-26 15:43 ` Joe Perches
2023-07-26 16:23   ` Jakub Kicinski
2023-07-26 16:45     ` Linus Torvalds
2023-07-26 16:51       ` Joe Perches
2023-07-26 18:20       ` Jakub Kicinski [this message]
2023-07-26 18:29         ` Linus Torvalds
2023-07-26 18:45           ` Limonciello, Mario
2023-07-26 18:48             ` Linus Torvalds
2023-07-26 18:48           ` Jakub Kicinski
2023-07-26 18:59             ` Linus Torvalds
2023-07-26 19:05               ` Linus Torvalds
2023-07-26 19:37                 ` Linus Torvalds
2023-07-26 20:03                   ` Jakub Kicinski
2023-07-26 20:13                     ` Linus Torvalds
2023-07-26 20:36                       ` Jakub Kicinski
2023-07-26 21:07                         ` Linus Torvalds
2023-07-26 21:57                           ` Jakub Kicinski
2023-07-26 22:02                             ` Linus Torvalds
2023-07-26 22:15                             ` Linus Torvalds
2023-07-26 23:47                             ` Konstantin Ryabitsev
2023-07-27  0:11                               ` Jakub Kicinski
2023-07-27  0:24                                 ` Konstantin Ryabitsev
2023-07-27  0:27                                   ` Jakub Kicinski
2023-07-27  0:33                                     ` Konstantin Ryabitsev
2023-07-27  1:07                                       ` Joe Perches
2023-07-27 11:00                                   ` Andrew Lunn
2023-07-28 20:29                                     ` Konstantin Ryabitsev
2023-07-28 20:38                                       ` Jakub Kicinski
2023-07-28 20:50                                         ` Konstantin Ryabitsev
2023-07-29  0:22                                       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230726112031.61bd0c62@kernel.org \
    --to=kuba@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=mario.limonciello@amd.com \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox