From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49691C7EE29 for ; Sun, 4 Jun 2023 18:33:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230070AbjFDSdw (ORCPT ); Sun, 4 Jun 2023 14:33:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbjFDSdw (ORCPT ); Sun, 4 Jun 2023 14:33:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59A19AB; Sun, 4 Jun 2023 11:33:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E1F1F60C5A; Sun, 4 Jun 2023 18:33:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06535C433D2; Sun, 4 Jun 2023 18:33:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685903630; bh=f9OEWGFCtPKI2b4MzFeQoinmiSfu+SBsi+GIqnpBvug=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V7aLN7nmeRaVCU5w3shveuB0uB9SCuAhN6eLAg7Oo/PhSyQzwM/UGr/hLE5AI3ocj m2qBzvf+rNcdCWUkNInqA+yp2c5Mv8q2VxKuZT2TUjimu08UJBHEn85TDJR6/wuBC7 /jsVRM9fPBCkJ4mgYSpvNRtCOKk5Rp5lbc0WveP2e+cxJCecOLIjaTnbiCtw57wLsM T5/bu9hsRnmd/zbtofyljRN58YtpZpDFp7F9SjbqhB8QQjg3SixZ/u6ikeTcPLcQGQ 0SRBWWtYkXbOVMDtetcoWuUCjepg+txKhwOUV9jjhKr05FWbO8wMeuCQlg+k5yrIJe Tr5KZMBLiV8kA== Date: Sun, 4 Jun 2023 11:33:49 -0700 From: Jakub Kicinski To: James Seo Cc: Jonathan Corbet , Kalle Valo , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] docs: process: Send patches 'To' maintainers and 'Cc' lists Message-ID: <20230604113349.495f8e79@kernel.org> In-Reply-To: <20230603151447.29288-1-james@equiv.tech> References: <20230603151447.29288-1-james@equiv.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: workflows@vger.kernel.org On Sat, 3 Jun 2023 08:14:47 -0700 James Seo wrote: > +You should always notify the appropriate subsystem maintainer(s) and list(s) s/notify/specify as recipients/ ? notify sounds like an out of band ping, maybe just to me. > +about any patch to code that they maintain. Identify them by looking through > +the MAINTAINERS file and the source code revision history, and by using the > +script scripts/get_maintainer.pl (pass paths to your patches as arguments to > +scripts/get_maintainer.pl). Send your patch e-mail "To:" those maintainers and > +"Cc:" those lists. There's a handful of people who run get_maintainer on the file paths, ./scripts/get_maintainer.pl net/core/dev.c rather than ./scripts/get_maintainer.pl 0001-my.patch This leads to ignoring Fixes tags, and authors of fixed commits should really be CCed. Since we're touching this paragraph maybe we can massage the wording a bit: (pass paths to your patches generated by git format-patch as arguments to scripts/get_maintainer.pl) > +If you cannot find a maintainer for the subsystem you are working on, Andrew > +Morton (akpm@linux-foundation.org) serves as a maintainer of last resort. Also, Thanks for the patch, btw, we also see To-less patches a couple times a month on netdev@ :(