workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Jakub Kicinski <kuba@kernel.org>, workflows@vger.kernel.org
Subject: Re: Monitoring the status of your own patches on patchwork?
Date: Mon, 13 Dec 2021 14:56:56 -0800	[thread overview]
Message-ID: <202112131456.64F9F954@keescook> (raw)
In-Reply-To: <87zgp4z6w0.fsf@toke.dk>

On Mon, Dec 13, 2021 at 07:39:27PM +0100, Toke Høiland-Jørgensen wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
> 
> > On Mon, 13 Dec 2021 16:48:37 +0100 Toke Høiland-Jørgensen wrote:
> >> > Status notification when checks are failing? Hopefully not, we don't
> >> > want people posting patches just to get them tested...  
> >> 
> >> Well no, but sometimes a patch will have failures despite the best
> >> efforts of the submitter (otherwise what's the point of the checks?).
> >> Right now the only way for me to discover that there's an issue is to go
> >> look at the patchwork web interface, and I wanted something that better
> >> suits my workflow (i.e., that's not in a web browser).
> >
> > I think that the maintainer should notify the submitter about 
> > the reason the patch state was changed (with the exception of
> > patches for a different tree, maybe). I know Kees has been 
> > trying to add more meaningful states to patchwork but I can
> > never guess the meaning of those either :S So no automated
> > state checker can replace the maintainer's reply.
> 
> Well, sometimes the maintainers forget to reply entirely :)
> 
> And yeah, I do realise that no bot is going to be able to tell me
> exactly what the current status is, I just want a tool to help me
> manually keep track...

I've mostly been trying to capture the state of the patch review
conversation with some kind of flag in patchwork. For KSPP, we've
documented it here:
https://kernsec.org/wiki/index.php/Kernel_Self_Protection_Project/Patch_Tracking

-- 
Kees Cook

  reply	other threads:[~2021-12-13 22:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-11 19:06 Toke Høiland-Jørgensen
2021-12-13 15:08 ` Jakub Kicinski
2021-12-13 15:48   ` Toke Høiland-Jørgensen
2021-12-13 16:06     ` Jakub Kicinski
2021-12-13 18:39       ` Toke Høiland-Jørgensen
2021-12-13 22:56         ` Kees Cook [this message]
2021-12-13 18:37 ` Simon Glass
2021-12-13 21:43   ` Toke Høiland-Jørgensen
2021-12-13 23:51     ` Simon Glass
2021-12-14  2:12   ` Randy Dunlap
2021-12-14 16:31     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202112131456.64F9F954@keescook \
    --to=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=toke@redhat.com \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox