workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Han-Wen Nienhuys <hanwen@google.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	workflows@vger.kernel.org
Subject: Re: RFC: using supersedes: trailer to indicate patch/series revision flow
Date: Fri, 8 Nov 2019 12:48:50 +0200	[thread overview]
Message-ID: <20191108104850.GA4866@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdXrPKUf5sJhw8s-NYCGpwDoLGOptN=poaCJb5dWDNkVaw@mail.gmail.com>

Hi Geert,

On Fri, Nov 08, 2019 at 10:59:55AM +0100, Geert Uytterhoeven wrote:
> On Fri, Nov 8, 2019 at 9:31 AM Han-Wen Nienhuys <hanwen@google.com> wrote:
> > On Fri, Nov 8, 2019 at 12:45 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > > > 2. Should supersedes: link to the previous version of the patch, or the
> > > >     first ever version of the patch? I am leaning towards the latter,
> > >
> > > And then how do you know that version 2 was superseded by version 3?
> >
> > You throw the message ID into a search engine, and see what it returns.
> >
> > The advantage of keeping the patch series ID stable is that you can
> > consider a patchseries as a document and then easily index it inside a
> > service (say, patchwork) using Lucene, ElasticSearch or some other
> > common technology.
> >
> > If you make the "supersedes" refer to specific versions, a workflow
> > service will be more susceptible to errors if messages were lost, and
> > the service has to work harder to aggregate the different versions of
> > a patchseries together.
> >
> > Is it common for different authors to superseed each other's patch
> > series? If yes, "superseeds: precise version" is more precise, if not,
> > you get the same information from the timestamp of the cover letter.
> 
> All/most of the above applies only to versioning of patch series that
> implement a fixed feature, with a fixed scope.
> So Vn+1 is really an improved version of Vn, and nothing more or less.
> 
> But this does not apply to many patch series in Linux kernel development.
> Patch series may
>   - grow (more patches added),

This shouldn't be a problem, as the new patches get posted for the first
time, and thus don't supersede anything else than what the previous
version of the series contained.

>   - shrink (some patches rejected, or already applied independently),

This should also not be an issue, as the patches that are dropped or
that are already applied will not be resubmitted separately.

>   - be split in multiple series,
>   - dropped but some parts reused in other series (possibly by someone
>     else),
>   - ...

These are the difficult cases :-(

> That's the hard work in patch tracking.
> 
> So series IDs do not cope well with this, and "superseded" really should
> apply to individual patches, not series, too.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2019-11-08 10:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 20:43 Konstantin Ryabitsev
2019-11-07 23:45 ` Rafael J. Wysocki
2019-11-08  8:30   ` Han-Wen Nienhuys
2019-11-08  9:59     ` Geert Uytterhoeven
2019-11-08 10:48       ` Laurent Pinchart [this message]
2019-11-08 11:00       ` Rafael J. Wysocki
2019-11-08  0:09 ` Andrew Donnellan
2019-11-08  9:19 ` Vegard Nossum
2019-11-08  9:46 ` Geert Uytterhoeven
2019-11-14  6:29 ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191108104850.GA4866@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=geert@linux-m68k.org \
    --cc=hanwen@google.com \
    --cc=konstantin@linuxfoundation.org \
    --cc=rjw@rjwysocki.net \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox