From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Eric Wong <e@80x24.org>
Cc: workflows@vger.kernel.org
Subject: Re: patch attachments still unwelcome?
Date: Fri, 1 Nov 2019 09:00:12 -0400 [thread overview]
Message-ID: <20191101130012.yxtbzz4olyr2hh3f@pure.paranoia.local> (raw)
In-Reply-To: <20191101022746.GA25491@dcvr>
On Fri, Nov 01, 2019 at 02:27:46AM +0000, Eric Wong wrote:
> The BDFL sets an example by attaching patches:
>
> https://lore.kernel.org/lkml/?q=f%3Atorvalds+n%3Apatch
>
> So the documentation in the kernel advising against sending
> patch attachments seems hypocritical. Changing the kernel docs
> allow patch attachments could be a good start to making life
> easier for contributors without SMTP or IMAP access.
>
> Are many MUAs still incapable of handling them?
It's not really that they are incapable of "handling" them, it's that
patches-as-attachments make it significantly harder to do code review in
a way that is convenient to developers. While some MUAs will properly
inline-quote an attached text/plain file when you hit "Reply All",
many others won't, requiring manual copy-pasting in order to comment on
actual patch contents.
-K
next prev parent reply other threads:[~2019-11-01 13:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 2:27 Eric Wong
2019-11-01 9:04 ` Greg KH
2019-11-04 13:13 ` Theodore Y. Ts'o
2019-11-04 13:23 ` Dmitry Vyukov
2019-11-04 14:49 ` Jani Nikula
2019-11-04 17:40 ` Geert Uytterhoeven
2019-11-05 10:46 ` Geert Uytterhoeven
2019-11-04 13:42 ` Greg KH
2019-11-04 13:42 ` Drew DeVault
2019-11-01 13:00 ` Konstantin Ryabitsev [this message]
2019-11-04 11:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101130012.yxtbzz4olyr2hh3f@pure.paranoia.local \
--to=konstantin@linuxfoundation.org \
--cc=e@80x24.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox