From: Greg KH <gregkh@linuxfoundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: workflows@vger.kernel.org
Subject: Re: script to check "Fixes:" tags
Date: Fri, 27 Sep 2019 20:01:33 +0200 [thread overview]
Message-ID: <20190927180133.GD1802011@kroah.com> (raw)
In-Reply-To: <CAMuHMdUq3if8bF0KatS+gWSa4mBvGk0Z8oyoOpeUj=AMTYbMkA@mail.gmail.com>
On Fri, Sep 27, 2019 at 09:49:55AM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Thu, Sep 26, 2019 at 9:51 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > Since this list was created to share scripts, here's one that I
> > currently use to test that the "Fixes:" tags are correct on a commit. I
> > run it on all patches that I accept into my trees, after getting emails
> > from Stephen one too many times :)
> >
> > It's almost entirely based on Stephen's original script, but has been
> > changed a bit in formatting and usage to be a stand-alone script that
> > anyone can use.
> >
> > To use:
> > verify_fixes.sh GIT_RANGE
> >
> > if all is good, script will print nothing out and exit with success. If
> > there is a problem it will be printed out and the script will exit with
> > an error that you can check from any other program.
> >
> > It it 'shellcheck' clean, but I'm sure that there are other things wrong
> > with it, so feel free to point out problems.
>
> Thanks!
>
> > And should stuff like this be in the kernel tree itself?
>
> Probably this should be integrated into checkpatch.pl?
I can't run checkpatch.pl on everything as sometimes I need to take
patches that do not pass it :)
checkpatch.pl is supposed to check for s-o-b but for some reason I don't
think it does all of the checking that my other script does. Or at
least I haven't noticed it.
thanks,
greg k-h
next prev parent reply other threads:[~2019-09-27 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 19:51 Greg KH
2019-09-27 7:08 ` Krzysztof Kozlowski
2019-09-27 7:49 ` Geert Uytterhoeven
2019-09-27 12:01 ` Rob Herring
2019-09-27 18:03 ` Greg KH
2019-09-27 18:01 ` Greg KH [this message]
2019-09-27 18:06 ` Geert Uytterhoeven
2019-09-27 18:35 ` Greg KH
2019-09-27 19:00 ` Geert Uytterhoeven
2019-09-27 19:46 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927180133.GD1802011@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=geert@linux-m68k.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox